-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: localnet wallet issue #970
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
- Coverage 81.45% 81.41% -0.04%
==========================================
Files 173 173
Lines 9188 9190 +2
==========================================
- Hits 7484 7482 -2
- Misses 1347 1350 +3
- Partials 357 358 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should fix our local-net wallet issue, but we can test it (and improve the wallet test also) by adding a genesis type to the wallet_test
setup function.
Also, we have some unrelated(?) failing tests on network gossip.
Yes, we have time-to-time issues that came from Libp2p. Ignore them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can fix failing tests by updating the default local net config test to this:
assert.Equal(t, conf.GRPC.Listen, "[::]:50052")
assert.Equal(t, conf.GRPC.Gateway.Listen, "[::]:0")
assert.Equal(t, conf.HTTP.Listen, "[::]:0")
assert.Equal(t, conf.Nanomsg.Listen, "tcp://[::]:40799")
@kehiy I think we can merge it now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me.
Thanks @b00f.
Description
This PR fixes the lcoalnet wallet issue that couldn't query the local node.