Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: localnet wallet issue #970

Merged
merged 5 commits into from
Jan 28, 2024
Merged

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Jan 27, 2024

Description

This PR fixes the lcoalnet wallet issue that couldn't query the local node.

@b00f b00f requested a review from kehiy January 27, 2024 19:58
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Merging #970 (eba3572) into main (1e831ae) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
- Coverage   81.45%   81.41%   -0.04%     
==========================================
  Files         173      173              
  Lines        9188     9190       +2     
==========================================
- Hits         7484     7482       -2     
- Misses       1347     1350       +3     
- Partials      357      358       +1     

Copy link
Contributor

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix our local-net wallet issue, but we can test it (and improve the wallet test also) by adding a genesis type to the wallet_test setup function.

Also, we have some unrelated(?) failing tests on network gossip.

@b00f
Copy link
Collaborator Author

b00f commented Jan 28, 2024

This should fix our local-net wallet issue, but we can test it (and improve the wallet test also) by adding a genesis type to the wallet_test setup function.

Also, we have some unrelated(?) failing tests on network gossip.

Yes, we have time-to-time issues that came from Libp2p. Ignore them

Copy link
Contributor

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can fix failing tests by updating the default local net config test to this:

assert.Equal(t, conf.GRPC.Listen, "[::]:50052")
assert.Equal(t, conf.GRPC.Gateway.Listen, "[::]:0")
assert.Equal(t, conf.HTTP.Listen, "[::]:0")
assert.Equal(t, conf.Nanomsg.Listen, "tcp://[::]:40799")

@b00f
Copy link
Collaborator Author

b00f commented Jan 28, 2024

@kehiy I think we can merge it now

Copy link
Contributor

@kehiy kehiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.
Thanks @b00f.

@kehiy kehiy merged commit 848a56f into pactus-project:main Jan 28, 2024
11 of 12 checks passed
@b00f b00f deleted the wallet-localhost-issue branch March 21, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants