Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transaction): supporting transfer #6

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

kehiy
Copy link
Collaborator

@kehiy kehiy commented Jul 22, 2024

@kehiy kehiy marked this pull request as draft July 22, 2024 20:47
@kehiy kehiy marked this pull request as ready for review August 12, 2024 10:27
@kehiy kehiy changed the title feat: supporting transactions feat: supporting transfer transactions Aug 12, 2024
@kehiy kehiy changed the title feat: supporting transfer transactions feat(transaction): supporting transfer Aug 12, 2024
@kehiy
Copy link
Collaborator Author

kehiy commented Aug 13, 2024

@b00f Transfer is already done. I decided to support transfer first. The only issues are:

  1. we can't run tests because of package and folder management. (I need to study PythonW package management more)
  2. I'm not sure where to calculate the fee in Transaction, amount, or Fee object. I think it must be a part of the Transaction.

@b00f
Copy link
Collaborator

b00f commented Aug 13, 2024

Any idea how to fix the broken pipe?

@kehiy
Copy link
Collaborator Author

kehiy commented Aug 13, 2024

Any idea how to fix the broken pipe?

@b00f Here I explained:

#6 (comment)

It's package issues. I think my requirements file has issues maybe...

@b00f b00f merged commit 4751051 into pactus-project:main Aug 14, 2024
1 of 2 checks passed
@kehiy kehiy deleted the feature/transaction branch August 17, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants