forked from moja-global/FLINT.Cloud
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor get_provider_config() #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, this restructuring is more logical. |
Here is the result for the GCBM_New_Demo_Run.zip:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey @padmajabhol - I tested out your code and got it mostly working. This now compiles compliant configuration for the GCBM_New_Demo_Run.
Major changes
rest_gcbm_api
folder so that they're persistent (a user never needs to know they're there) and updatedcurl.md
.How Has This Been Tested?
Steps to reproduce:
Additional Context (Please include any Screenshots/gifs if relevant)
Checklist:
There's a bit more to do, but this is starting to look really good! See how much easier our
curl
call is 💯 🏆We really need an integration test that checks the results are the same as GCBM_Demo_Run. Maybe we can ask Namya for help?