Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Deprecated packages #2353

Closed
3ae3ae opened this issue Jun 18, 2024 · 2 comments · Fixed by #3213
Closed

[Enhancement] Deprecated packages #2353

3ae3ae opened this issue Jun 18, 2024 · 2 comments · Fixed by #3213
Labels
(Legacy) Bug Legacy Label, don't apply to new issues/PRs

Comments

@3ae3ae
Copy link
Contributor

3ae3ae commented Jun 18, 2024

While installing the program, I found that two packages are deprecated.

npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.

npm warn deprecated koa-router@10.1.1: IMPORTANT 10x+ PERFORMANCE UPGRADE: Please upgrade to v12.0.1+ as we have fixed an issue with debuglog causing 10x slower router benchmark performance, see koajs/router#173

Inflight should be replaced with lru-cache, and koa-router should be updated.
In particular, inflight has a memory leak issue.

@3ae3ae 3ae3ae added the (Legacy) Bug Legacy Label, don't apply to new issues/PRs label Jun 18, 2024
@3ae3ae 3ae3ae closed this as completed Jun 18, 2024
@Tempo-anon
Copy link
Collaborator

Going to keep this issue open until inflight is ripped out

@torranx
Copy link
Collaborator

torranx commented Aug 7, 2024

Resolved in #3213

@torranx torranx closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Legacy) Bug Legacy Label, don't apply to new issues/PRs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants