Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependencies] Update to resolve install warnings (after beta rebase) #3213

Merged
merged 16 commits into from
Jul 30, 2024

Conversation

flx-sta
Copy link
Collaborator

@flx-sta flx-sta commented Jul 29, 2024

What are the changes?

As requested by @Tempo-anon I've cleaned the dependencies up.
Meaning version bumps, remove unused etc.

closes #2353
duplicate of #3160

ℹ️ After merging this

we should consider adding dependabot to the project
see #2433

Why am I doing these changes?

Mainly to close vulnerabilities and to resolve warnings thrown during the npm i run.

What did change?

  1. ⬆️ bump up vitest and eslint version to resolve inflight warning
    • ❌ remove and disable eslint-plugin-import due to not supporting eslint@9 yet (can be reactivated later)
    • ⬆️ bump eslint to 9.7.0.
      • ⬆️ bump @typescript-eslint/eslint-plugin to 8.0.0-alpha.54
      • ⬆️ update @typescript-eslint/parser to 8.0.0-alpha.54
      • ⬆️ update typescript-eslint to 8.0.0-alpha.54
      • ❌ remove eslint-plugin-import as it's not compatible with eslint 9 yet => see Support eslint v9 import-js/eslint-plugin-import#2948
    • ⬆️ update vitest to 2.0.4
      • ⬆️ update @vitest/coverage-istanbul to 2.0.4
  2. ❌ remove vite-plugin-fs dependency
    • removed api-generatort-script.ts file (this was in consultations with devs discord-message)
  3. ⬆️ bump vite to version 5
  4. 🔀 migrate some typescript-eslint to @stylistic/eslint-plugin-ts
  5. ❌ delete pokenode-ts dependency (unused)
  6. ❌ remove axios and axios-cache-interceptor dependency (unused, DOM integrated fetch is being used)
  7. ❌ remove unused json-beautify dependency
  8. 🔁 move dependency-cruiser to dev dependencies

Screenshots/Videos

image image image

How to test the changes?

  • run npm i or npm ci => no warnings. No vulnerabilities.
  • run npm run build => should still work as expected
  • run npm run test:silent => shouldn't fail
  • run npm run docs => no errors (plenty of warnings. That's normal)
  • run npm run eslint-ci => no warnings
  • run npm run start => should start as expected

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • [] Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [] Are the changes visual?
    • [] Have I provided screenshots/videos of the changes?

- remove and disable `eslint-plugin-import` due to not supporting `eslint@9` yet (can be reactivated later)
- bump `eslint` to `9.7.0`.
  - bump `@typescript-eslint/eslint-plugin` to `8.0.0-alpha.54`
  - update `@typescript-eslint/parser` to `8.0.0-alpha.54`
  - update `typescript-eslint` to `8.0.0-alpha.54`
- update `vitest` to `2.0.4`
  - update `@vitest/coverage-istanbul` to `2.0.4`
It should ignore hidden (starting with `.`) files!
It's a WebGL debugging tool but I've never seen anyone using it
@flx-sta flx-sta self-assigned this Jul 29, 2024
@flx-sta flx-sta added Enhancement New feature or request Miscellaneous Changes that don't fit under any other label labels Jul 29, 2024
@flx-sta flx-sta marked this pull request as ready for review July 29, 2024 14:58
@flx-sta flx-sta changed the base branch from main to beta July 29, 2024 15:17
@Tempo-anon Tempo-anon merged commit cb7dbe6 into pagefaultgames:beta Jul 30, 2024
4 checks passed
@flx-sta flx-sta deleted the update-dependencies-2 branch July 30, 2024 05:34
@flx-sta flx-sta removed their assignment Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Miscellaneous Changes that don't fit under any other label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Deprecated packages
2 participants