-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dependencies] Update to resolve install warnings (after beta rebase) #3213
Merged
Tempo-anon
merged 16 commits into
pagefaultgames:beta
from
flx-sta:update-dependencies-2
Jul 30, 2024
Merged
[Dependencies] Update to resolve install warnings (after beta rebase) #3213
Tempo-anon
merged 16 commits into
pagefaultgames:beta
from
flx-sta:update-dependencies-2
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove and disable `eslint-plugin-import` due to not supporting `eslint@9` yet (can be reactivated later) - bump `eslint` to `9.7.0`. - bump `@typescript-eslint/eslint-plugin` to `8.0.0-alpha.54` - update `@typescript-eslint/parser` to `8.0.0-alpha.54` - update `typescript-eslint` to `8.0.0-alpha.54` - update `vitest` to `2.0.4` - update `@vitest/coverage-istanbul` to `2.0.4`
- removed `api-generatort-script.ts` file (this was in consultations with devs https://discord.com/channels/1125469663833370665/1250836282926436413/1266469312609259550)
It should ignore hidden (starting with `.`) files!
as stated here: https://typescript-eslint.io/blog/deprecating-formatting-rules#upgrading-to-eslint-stylistic - fix eslint complaints inside `i18next.d.ts`
It's a WebGL debugging tool but I've never seen anyone using it
They are unused
This reverts commit 725e681.
flx-sta
added
Enhancement
New feature or request
Miscellaneous
Changes that don't fit under any other label
labels
Jul 29, 2024
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
As requested by @Tempo-anon I've cleaned the dependencies up.
Meaning version bumps, remove unused etc.
closes #2353
duplicate of #3160
Why am I doing these changes?
Mainly to close vulnerabilities and to resolve warnings thrown during the
npm i
run.What did change?
eslint-plugin-import
due to not supportingeslint@9
yet (can be reactivated later)eslint
to9.7.0
.@typescript-eslint/eslint-plugin
to8.0.0-alpha.54
@typescript-eslint/parser
to8.0.0-alpha.54
typescript-eslint
to8.0.0-alpha.54
eslint-plugin-import
as it's not compatible with eslint 9 yet => see Support eslint v9 import-js/eslint-plugin-import#2948vitest
to2.0.4
@vitest/coverage-istanbul
to2.0.4
api-generatort-script.ts
file (this was in consultations with devs discord-message)fetch
is being used)Screenshots/Videos
How to test the changes?
npm i
ornpm ci
=> no warnings. No vulnerabilities.npm run build
=> should still work as expectednpm run test:silent
=> shouldn't failnpm run docs
=> no errors (plenty of warnings. That's normal)npm run eslint-ci
=> no warningsnpm run start
=> should start as expectedChecklist
beta
as my base branch[] Have I considered writing automated tests for the issue?npm run test
)[] Are the changes visual?[] Have I provided screenshots/videos of the changes?