Implement Poison Heal Ability #1245
Conversation
There was a problem hiding this comment.
Code looks mostly okay to me, just had some comments.
Can you also test this with things like neutralizing gas, skill swap, and toxic?
When a Pokémon with Poison Heal is badly poisoned, this has no effect on the Pokémon's HP recovery. However, the bad poison counter still increases each turn even if the Pokémon has Poison Heal; as such, if Gastro Acid is used on the Pokémon with Poison Heal after being badly poisoned for five turns, it will incur poison damage starting at 5/16 (instead of 1/16).
I have done some of the updates you thought would be good. @TempsRay Video to show the new notification system (only showAbility when actually healing) NewShowAbility.mp4Video to show Neutralizing Gas: NeutralizingGas.mp4Video to show Skill Swap SkilSwap.mp4For Toxic, it should be in the original post, the first video. |
EvasiveAce
force-pushed
the
poison-heal-branch
branch
2 times, most recently
from
5ef6dbf
to
f57ae47
Compare
src/data/ability.ts
Outdated
| @@ -2293,6 +2312,29 @@ export class PostTurnAbAttr extends AbAttr { | |||
| } | |||
| } | |||
|
|
|||
| export class PostTurnPoisonHealAbAttr extends PostTurnAbAttr { | |||
There was a problem hiding this comment.
Can you add some documentation on this class and the BlockPoisonToxicDamageAbAttr class to explain at a quick glance what it does and where it's used (Poison Heal)?
/**
* Ability attribute to heal the user if the user is poisoned or toxic'd. Used by Poison Heal
*/
There was a problem hiding this comment.
Is the newest commit better?
…ND COMMENTED AGAIN
…(); Also added better documentation
I changed the way healing is done from Heal() to a HealPhaseVideo to show how Toxic works with the new phase: Tox.mp4Video to show the same thing but with Poison Powder: PoisonPowd.mp4 |
ability-trigeer.ts windPowerCharged: Wind Power/Wind Rider pagefaultgames#1566 Perish Body pagefaultgames#1554 Poison Heal pagefaultgames#1245 menu.ts Loading screen disclaimer 7c9e5e9 modifier-type.ts TM description with overlay key notice pagefaultgames#1585
* [Localization] Apply Korean to update ability-trigeer.ts windPowerCharged: Wind Power/Wind Rider #1566 Perish Body #1554 Poison Heal #1245 menu.ts Loading screen disclaimer 7c9e5e9 modifier-type.ts TM description with overlay key notice #1585 * Correct wrong text and align text width change RV remove space from FGEN * Edit wrong space * Use special color(official) rather than unofficial shiny * Translate iceFaceAvoidedDamage
* [Localization] Apply Korean to update ability-trigeer.ts windPowerCharged: Wind Power/Wind Rider pagefaultgames#1566 Perish Body pagefaultgames#1554 Poison Heal pagefaultgames#1245 menu.ts Loading screen disclaimer 7c9e5e9 modifier-type.ts TM description with overlay key notice pagefaultgames#1585 * Correct wrong text and align text width change RV remove space from FGEN * Edit wrong space * Use special color(official) rather than unofficial shiny * Translate iceFaceAvoidedDamage
* Implement Poison Heal Ability * Removed unneeded import * Fix some comments, as well as make Poison Heal only notify when healing * Eslint fix * Revert Phases * Pushing for sake of reviewing; PR IS NOT DONE IT NEEDS TO BE TESTED AND COMMENTED AGAIN * Changed the way healing is done, through a heal phase instead of heal(); Also added better documentation * Changed healing, as well as making abilityTriggers updated
* [Localization] Apply Korean to update ability-trigeer.ts windPowerCharged: Wind Power/Wind Rider pagefaultgames#1566 Perish Body pagefaultgames#1554 Poison Heal pagefaultgames#1245 menu.ts Loading screen disclaimer 7c9e5e9 modifier-type.ts TM description with overlay key notice pagefaultgames#1585 * Correct wrong text and align text width change RV remove space from FGEN * Edit wrong space * Use special color(official) rather than unofficial shiny * Translate iceFaceAvoidedDamage
* Implement Poison Heal Ability * Removed unneeded import * Fix some comments, as well as make Poison Heal only notify when healing * Eslint fix * Revert Phases * Pushing for sake of reviewing; PR IS NOT DONE IT NEEDS TO BE TESTED AND COMMENTED AGAIN * Changed the way healing is done, through a heal phase instead of heal(); Also added better documentation * Changed healing, as well as making abilityTriggers updated
* [Localization] Apply Korean to update ability-trigeer.ts windPowerCharged: Wind Power/Wind Rider pagefaultgames#1566 Perish Body pagefaultgames#1554 Poison Heal pagefaultgames#1245 menu.ts Loading screen disclaimer 7c9e5e9 modifier-type.ts TM description with overlay key notice pagefaultgames#1585 * Correct wrong text and align text width change RV remove space from FGEN * Edit wrong space * Use special color(official) rather than unofficial shiny * Translate iceFaceAvoidedDamage
Implements the Poison Heal Ability
Please let me know if there is anything I can change or improve on. Thank you.
Video to show that Toxic works as intended:
Toxic.mp4
Video to show that Poison Powder works as intended;
Poison.Powder.mp4