Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QoL] Skip pre-commit on merge and rebase, add pre-push #1607

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

OrangeRed
Copy link
Collaborator

@OrangeRed OrangeRed commented May 30, 2024

What are the changes?

Update lefthook config so it isn't as disruptive.

Why am I doing these changes?

To open a discussion as to what is the most ergonomic way to use git hooks.
Running eslint every time we merge or rebase the newest changes from main feels bad

What did change?

Lefthook config options

Screenshots/Videos

N/A

How to test the changes?

Checkout the branch and make some dummy commits / merges / rebases

Checklist

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Tempo-anon Tempo-anon added the Enhancement New feature or request label May 30, 2024
@OrangeRed
Copy link
Collaborator Author

@Greenlamp2 Do you think the pre-push hook is worth keeping if we run the pre-commit hook on (almost) every commit?

@Greenlamp2
Copy link
Collaborator

@Greenlamp2 Do you think the pre-push hook is worth keeping if we run the pre-commit hook on (almost) every commit?

i think at some point we should replace completely the pre-commit by a pre-push

@flx-sta flx-sta marked this pull request as ready for review August 25, 2024 00:16
@flx-sta flx-sta added the Lead Dev Review Lead Dev Review is required label Aug 25, 2024
@f-fsantos f-fsantos added this pull request to the merge queue Sep 5, 2024
Merged via the queue into pagefaultgames:beta with commit 41bb12d Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Lead Dev Review Lead Dev Review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants