[Bug] Fix for Dancer activating when enemy in not on field / using a 2 steps charging move #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tempo-anon
added
(Legacy) Bug
Tempo-anon
approved these changes
Jun 3, 2024
Jason954
pushed a commit
to Jason954/pokerogue
that referenced
this pull request
Jun 6, 2024
…2 steps charging move (pagefaultgames#1708) * Fixes !1686 and !1450 * Added forbidden tags * Restored original import indentations * Restored missing import
Korwai
pushed a commit
to Korwai/pokerogue
that referenced
this pull request
Jun 14, 2024
…2 steps charging move (pagefaultgames#1708) * Fixes !1686 and !1450 * Added forbidden tags * Restored original import indentations * Restored missing import
SavGRY
pushed a commit
to SavGRY/pokerogue
that referenced
this pull request
Jun 16, 2024
…2 steps charging move (pagefaultgames#1708) * Fixes !1686 and !1450 * Added forbidden tags * Restored original import indentations * Restored missing import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
Fix for #1686 and #1450
What did change?
Fixed a bug where Dancer activates while a Pokemon with Dancer Ability is charging a 2 turns move.
Fixed a bug where Dancer activates while a Pokemon with Dancer Ability is on the opponent team but not on the field.
Screenshots/Videos
Before
2024-06-02.01-08-21.mp4
After
2024-06-02.01-09-14.mp4
How to test the changes?
Have a pokemon having the Dancer abilty use fly and use a dancing move afterwards.
Have a pokemon having the Dancer abilty on the opponent team but not in the field and use a dancing move.
Checklist
npm run test)