[QoL] Summary option when new Pokemon caught and party is full #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrangeRed
suggested changes
Jul 2, 2024
|
I saw the test results - will fix tonight. |
…to summaryOption1
|
|
flx-sta
requested changes
Jul 3, 2024
flx-sta
requested changes
Jul 3, 2024
There was a problem hiding this comment.
1 thing I noticed is that the "learn move" phase seems to now go AFTER the next encounter phase( you can see that in video I posted before)
On live this is not the case. It's as described in Should
To clarify:
Is
- caught pokemon + prompt
- next counter
- learn new move prompt
- ...
Should
- caught pokemon + prompt
-
- learn new move prompt
- next counter
- ...
flx-sta
approved these changes
Jul 3, 2024
Fontbane
suggested changes
Jul 3, 2024
|
Tested @Fontbane's changes for the errors above and in the previous PR - found nothing wrong + looks good! thank you :) |
flx-sta
approved these changes
Jul 4, 2024
Tempo-anon
approved these changes
Jul 5, 2024
flx-sta
added a commit
to flx-sta/pokerogue
that referenced
this pull request
Jul 5, 2024
This was referenced Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated because of git issues
Original Found at : #2210
What are the changes?
When a player's party is full, they are presented with yes/no options to add the Pokemon to the party or release the newly caught Pokemon. This adds a 'SUMMARY' option so that the player could look at the caught Pokemon's summary before making a decision.
Why am I doing these changes?
I decided to make these decisions following a discussion in the Discord about the UI and the player's access to essential information regarding party formation. In addition, this feature brings PokeRogue in line to the mainline Pokemon games, which do allow the player to look at the summary page of a newly caught Pokemon.
What did change?
This alters the presentation of confirm-ui-handler.ts when a new Pokemon is caught and the player's party is at max from {YES, NO} to {SUMMARY, YES, NO}
In addition, it changes summary-ui-handler.ts behavior in regards to the cancellation button using differences found in setModeWithoutClear() and setMode(). The video will be also demonstrating that the Summary-UI in other occasions has not been altered in behavior in the comments.
Screenshots/Videos
Please see Discord. https://discord.com/channels/1125469663833370665/1249614808400007198/1249614815345901629
How to test the changes?
Catch a Pokemon with a full party.
Checklist
npm run test)