[Bug] block input while waiting for transition to prevent changing starter during move select #2342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
This uses the existing blockInput flag to prevent inputs from changing the starter when opening the manage moves menu.
Why am I doing these changes?
addresses these copies of the same bug
#1879
#2283
What did change?
Previously inputs that happened in between the triggering of swap to options mode and before it completed would be handled by the starter select, changing the starter selection.
Screenshots/Videos
a video wouldn't really prove that i'm hitting the buttons as described in the bug ;/
How to test the changes?
Pull this down, open starter select, pick bulbasaur and very quickly input a right movement action.
Previously bulbasaur's moveset would open with charmander selected
With this branch bulbasaur's moves are shown and bulbasaur remains the selection
Checklist
npm run test
)