Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] block input while waiting for transition to prevent changing starter during move select #2342

Merged

Conversation

scottarrr
Copy link
Contributor

@scottarrr scottarrr commented Jun 17, 2024

What are the changes?

This uses the existing blockInput flag to prevent inputs from changing the starter when opening the manage moves menu.

Why am I doing these changes?

addresses these copies of the same bug
#1879
#2283

What did change?

Previously inputs that happened in between the triggering of swap to options mode and before it completed would be handled by the starter select, changing the starter selection.

Screenshots/Videos

a video wouldn't really prove that i'm hitting the buttons as described in the bug ;/

How to test the changes?

Pull this down, open starter select, pick bulbasaur and very quickly input a right movement action.
Previously bulbasaur's moveset would open with charmander selected
With this branch bulbasaur's moves are shown and bulbasaur remains the selection

Checklist

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Madmadness65 Madmadness65 added the (Legacy) Bug Legacy Label, don't apply to new issues/PRs label Jun 17, 2024
src/ui/starter-select-ui-handler.ts Show resolved Hide resolved
@f-fsantos f-fsantos changed the base branch from main to beta July 10, 2024 17:47
@scottarrr
Copy link
Contributor Author

@brain-frog @f-fsantos Sorry for the ping, I see the base branch was swapped to beta but I'm not all that familiar with the process here. Is there anything waiting on me?

@scottarrr
Copy link
Contributor Author

@Tempo-anon Is this still needed? I see the bugs were closed so lmk if I should close this out too.

@Tempo-anon Tempo-anon dismissed brain-frog’s stale review July 30, 2024 17:12

Added to nature menu

@Tempo-anon Tempo-anon merged commit 3fbab84 into pagefaultgames:beta Jul 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Legacy) Bug Legacy Label, don't apply to new issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants