Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ability] Fully implement Pastel Veil, update Sweet Veil (after beta fix) #3208

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

torranx
Copy link
Collaborator

@torranx torranx commented Jul 29, 2024

duplicate of #2626 since beta is broken

What are the changes?

  • fully implement Pastel Veil
  • update Sweet Veil to apply to ally (still partial because the ally should ignore it if it has abilities like mold breaker)
  • fixes error from triggering battler tag immunity

Why am I doing these changes?

  • not fully implemented ability (pastel veil)
  • missing immunity to ally (sweet veil)
  • error occurs when battler tag immunity is triggered

What did change?

  • changed the existing StatusEffectImmunityAbAttr and BattlerTagImmunityAbAttr to be base classes for both single/field AbAttrs

Screenshots/Videos

How to test the changes?

Pastel Veil

  • Overriding ability won't work here since the override will apply to both pokemon on double battle. Instead, you can move Galar Ponyta's second ability (Pastel Veil) to first index in src/data/pokemon-species.ts.
  • DOUBLE_BATTLE_OVERRIDE = true
  • STARTER_SPECIES_OVERRIDE = Species.GALAR_PONYTA
  • OPP_MOVESET_OVERRIDE to have poison moves like TOXIC, POISON_GAS, etc
  • read linked ability for test expectation

Sweet Veil

  • STARTER_SPECIES_OVERRIDE = Species.SWIRLIX
  • DOUBLE_BATTLE_OVERRIDE = true
  • OPP_MOVESET_OVERRIDE to have sleep moves like POWDER
  • MOVESET_OVERRIDE = [Moves.REST]
  • read linked ability for test expectation

OR

$ npm run test pastel_veil
$ npm run test sweet_veil

Checklist

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Madmadness65 Madmadness65 added the Ability Affects an ability label Jul 29, 2024
src/data/ability.ts Outdated Show resolved Hide resolved
@torranx torranx requested a review from Tempo-anon July 30, 2024 05:35
@torranx torranx changed the title [Ability] Fully implement Pastel Veil, update Sweet Veil [Ability] Fully implement Pastel Veil, update Sweet Veil (after beta fix) Jul 30, 2024
@Tempo-anon Tempo-anon merged commit 5b4a248 into pagefaultgames:beta Jul 30, 2024
4 checks passed
@torranx torranx deleted the ability-pastel_sweet_veil branch October 4, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants