[Hotfix] Allow to hatch pokemon with Hidden Ability again #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tempo-anon
approved these changes
Jul 29, 2024
Tempo-anon
added a commit
that referenced
this pull request
Jul 30, 2024
* [Hotfix] Fix interactions of some moves not changing types (#3183) * [Hotfix] Fix wild spawns not having their HA (#3190) * [Hotfix] Allow to hatch pokemon with Hidden Ability again (#3222) * chore: Update TNC links layout and position in index.html * chore: Update TNC links font size in index.css (#3230) --------- Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com> Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com> Co-authored-by: Frederico Santos <frederico.f.santos@tecnico.ulisboa.pt>
tlelievre26
pushed a commit
to tlelievre26/pokerogue
that referenced
this pull request
Aug 5, 2024
ajhyperbit
added a commit
to ajhyperbit/pokerogue
that referenced
this pull request
Aug 7, 2024
…mes#3187) * chore: Add Termly consent preferences and policies links Added Termly consent preferences link and links to Privacy Policy, Cookie Disclaimer, Terms & Conditions, and Acceptable Use Policy in the HTML file. Also included a script for blocking resources from Termly. * feat: Add consent preferences menu option This commit adds a new menu option for "Consent Preferences" in the UI. When clicked, it triggers a click event on the consent link element and focuses on it. This allows users to easily access and manage their consent preferences. chore: Update links layout and position in index.html change pokeball catch rates increase voucher and masterball amounts change candy rates to 8x normal personal code workspace set package to host server on network [QoL] Toggle TNC display visibility (pagefaultgames#3210) * toggle TNC display visibility on end of Title phase * move TNC toggle to helper util * update to use stylesheet * dynamically move TNC links according to window size * adjust TNC link spacing * adjust TNC link spacing * add early escape if links element not found * remove link hide functionality --------- Co-authored-by: ImperialSympathizer <imperialsympathizer@gmail.com> Merge pull request pagefaultgames#3221 from pagefaultgames/beta Disclaimers [Hotfix] Allow to hatch pokemon with Hidden Ability again (pagefaultgames#3222) chore: Update TNC links layout and position in index.html Merge pull request pagefaultgames#3225 from pagefaultgames/disclaimers-mobile-hotfix chore: Update TNC links layout and position in index.html chore: Update TNC links font size in index.css (pagefaultgames#3230) Merge branch 'pagefaultgames:main' into aj tired of rng catch, everything is masterball now ignore nohup.out add saves newest save
f-fsantos
added a commit
that referenced
this pull request
Aug 10, 2024
* [Hotfix] Fix interactions of some moves not changing types (#3183) * [Hotfix] Fix wild spawns not having their HA (#3190) * [Hotfix] Allow to hatch pokemon with Hidden Ability again (#3222) * chore: Update TNC links layout and position in index.html * chore: Update TNC links font size in index.css (#3230) * Move Touch Controls * ConfigToolbar alignment * Insert config toolbar on open, camel-case classes, hidden setting * Better toolbar styling, fixed double configToolbar bug * Fixed typedocs --------- Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com> Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com> Co-authored-by: Frederico Santos <frederico.f.santos@tecnico.ulisboa.pt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I could have sworn I already made a PR for this...)
What are the changes?
Users are able to hatch Pokémon with hidden abilities again.
Why am I doing these changes?
It's not possible to hatch some Pokémon with hidden abilities right now.
What did change?
Pokemon that should hatch with hidden abilities are properly set to
abilityIndex = 2.How to test the changes?
Enable the egg override(s) and hatch lots of eggs.
Checklist
[ ] I'm usingbetaas my base branchnpm run test)[ ] Are the changes visual?[ ] Have I provided screenshots/videos of the changes?