Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix affixes appearing when they shouldn't #3236

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

Tempo-anon
Copy link
Collaborator

@Tempo-anon Tempo-anon commented Jul 30, 2024

What are the changes?

Fixed some incorrect strings

Why am I doing these changes?

Fixes bug introduced in #2570

What did change?

Reverted some incorrect name changes

Screenshots/Videos

Before:
trainer send out

party full

After:
trainer send out

party full

How to test the changes?

Get a full party and catch a Pokemon then fight the trainer on floor 5

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Tempo-anon Tempo-anon added (Legacy) Bug Legacy Label, don't apply to new issues/PRs Localization Provides or updates translation efforts labels Jul 30, 2024
Copy link
Contributor

@EnochG1 EnochG1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Korean is okay.

image
Before (Wild ~)

image
After (just pokemon name)

@Tempo-anon Tempo-anon merged commit e5f458d into pagefaultgames:beta Aug 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Legacy) Bug Legacy Label, don't apply to new issues/PRs Localization Provides or updates translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants