Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing } in the all localization strings #3258

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

CodeTappert
Copy link
Collaborator

@CodeTappert CodeTappert commented Jul 30, 2024

What are the changes?

  • I added } to all strings that hasnt had it

Why am I doing these changes?

  • because the placeholders were not correctly replaced

What did change?

  • They were missing i added them

Screenshots/Videos

None. Just do code review

How to test the changes?

Use the affected moves in the certain languages

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Tempo-anon Tempo-anon added the Localization Provides or updates translation efforts label Jul 30, 2024
@Tempo-anon Tempo-anon merged commit 74064d0 into pagefaultgames:beta Jul 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Provides or updates translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants