Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Consolidate the switch cases in IvyCudgelTypeAttr #3261

Merged

Conversation

DayKev
Copy link
Collaborator

@DayKev DayKev commented Jul 31, 2024

What are the changes?

There are no user-facing changes.

Why am I doing these changes?

General code clean-up.

What did change?

A switch statement was condensed in IvyCudgelTypeAttr.

How to test the changes?

Ivy Cudgel is currently broken in beta but were it not broken this change shouldn't cause problems regardless.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • [ ] Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [ ] Are the changes visual?
    • [ ] Have I provided screenshots/videos of the changes?

@Tempo-anon Tempo-anon added the Move Affects a move label Jul 31, 2024
@Tempo-anon Tempo-anon merged commit 495284a into pagefaultgames:beta Jul 31, 2024
4 checks passed
@DayKev DayKev deleted the consolidate-ivycudgeltypeattr branch August 2, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Move Affects a move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants