Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add female and double grunts #3280

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

Tempo-anon
Copy link
Collaborator

@Tempo-anon Tempo-anon commented Aug 1, 2024

What are the changes?

  • Allowed female grunts to show up (cosmetic change)
  • Allows evil team grunts to spawn as double battles
  • Did some code refactoring
  • Added localization for languages without the grunt translations

Why am I doing these changes?

We had the assets for this but never implemented it

What did change?

  • battle.ts
    • Added documentation to getRandomTrainerFunc
    • Added a new optional randomGender variable to getRandomTrainerFunc
    • The previous double battle code was never working (and also had a bug) but I repurposed it to only work for evil team grunts
  • Localizations
  • EN
  • DE
  • ES
  • FR
  • IT
  • KO
  • PT_BR
  • ZH_CN
  • ZH_TW

Screenshots/Videos

Female grunts generating alongside male grunts

Double grunts

How to test the changes?

Override to wave 61

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Tempo-anon Tempo-anon added Enhancement New feature or request Localization Provides or updates translation efforts labels Aug 1, 2024
Copy link
Contributor

@Adri1 Adri1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added French (+tiny correction on existing translation)

src/locales/fr/trainers.ts Outdated Show resolved Hide resolved
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Copy link
Collaborator

@frutescens frutescens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it looks good!

Copy link
Contributor

@NicusPulcis NicusPulcis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Italian localization

src/locales/it/trainers.ts Outdated Show resolved Hide resolved
Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>
src/locales/ko/trainers.ts Outdated Show resolved Hide resolved
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Tempo-anon and others added 2 commits August 2, 2024 11:28
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
@Tempo-anon Tempo-anon merged commit 52ef92a into pagefaultgames:beta Aug 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Localization Provides or updates translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants