Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] add missed move trigger and remove getPokemonMessage #3281

Merged

Conversation

EnochG1
Copy link
Contributor

@EnochG1 EnochG1 commented Aug 1, 2024

What are the changes?

Add the option to localize message texts of some move-trigger which are not localized.

list of messages & poke corpus message key (Just refer it, message can be different with og game.)

healHp : sv.btl_set.BTL_STRID_SET_HP_Recover)
sacrificialFullRestore (subject is different with pokerogue) : sv.btl_set.BTL_STRID_SET_IyasiNoNegai
invertStats : sv.btl_set.BTL_STRID_SET_Hikkurikaesu
resetStats : sv.btl_std.BTL_STRID_STD_RankReset
faintCountdown : sv.btl_std.BTL_STRID_STD_HorobiNoSango
copyType : swsh.btl_set.BTL_STRID_SET_MirrorType
suppressAbilities : sv.btl_set.BTL_STRID_SET_Ieki
swapArenaTags : sv.btl_set.BTL_STRID_SET_CourtChange

Why am I doing these changes?

All text should be localizable.

What did change?

  • Change hard-coded message for localize > src/data/move.ts
  • Added localization keys in each language folders. > move-trigger.ts
  • Edit EN copyType message following og game.
  • Remove redundant method > getPokemonMessage
  • Translated them to Korean. (+ each language after review)

Screenshots/Videos

En

Click to expand/collapse
Case Result
healHp image
sacrificialFullRestore image
invertStats image
resetStats image
faintCountdown image
copyType image
suppressAbilities image
swapArenaTags image

It

Click to expand/collapse
Case Result
healHp image
sacrificialFullRestore image
invertStats image
resetStats image
faintCountdown image
copyType image
suppressAbilities image
swapArenaTags image

Fr

Click to expand/collapse
Case Result
healHp image
sacrificialFullRestore image
invertStats image
resetStats image
faintCountdown image
copyType image
suppressAbilities image
swapArenaTags image

De

Click to expand/collapse
Case Result
healHp image
sacrificialFullRestore image
invertStats image
resetStats image
faintCountdown image
copyType image
suppressAbilities image
swapArenaTags image

Zh_CN

Click to expand/collapse
Case Result
healHp image
sacrificialFullRestore image
invertStats image
resetStats image
faintCountdown image
copyType image
suppressAbilities image
swapArenaTags image

Zh_TW

Click to expand/collapse
Case Result
healHp image
sacrificialFullRestore image
invertStats image
resetStats image
faintCountdown image
copyType image
suppressAbilities image
swapArenaTags image

Ko

Click to expand/collapse
Case Result
healHp image
sacrificialFullRestore image
invertStats image
resetStats image
faintCountdown image
copyType image
suppressAbilities image
swapArenaTags image

How to test the changes?

Manually (with src/overrides.ts)

List of test-able moves

healHp

  • Moves.RECOVER, Moves.SOFT_BOILED, Moves.MILK_DRINK, Moves.SLACK_OFF, Moves.HEAL_PULSE...

sacrificialFullRestore

  • Moves.HEALING_WISH

invertStats

  • Moves.TOPSY_TURVY

resetStats

  • Moves.HAZE, Moves.CLEAR_SMOG, Moves.FREEZY_FROST

faintCountdown

  • Moves.PERISH_SONG

copyType

  • Moves.REFLECT_TYPE

suppressAbilities

  • Moves.GASTRO_ACID

swapArenaTags

  • Moves.COURT_CHANGE

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@EnochG1 EnochG1 changed the base branch from main to beta August 1, 2024 03:38
Copy link
Contributor

@mercurius-00 mercurius-00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zh-CN and zh-TW

src/locales/zh_TW/move-trigger.ts Outdated Show resolved Hide resolved
src/locales/zh_CN/move-trigger.ts Outdated Show resolved Hide resolved
EnochG1 and others added 2 commits August 1, 2024 13:02
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
@Madmadness65 Madmadness65 added the Localization Provides or updates translation efforts label Aug 1, 2024
EnochG1 and others added 2 commits August 1, 2024 17:17
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Copy link
Contributor

@mercurius-00 mercurius-00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(zh-CN, zh-TW)
change sacrificialFullRestore to match original game text

src/locales/zh_TW/move-trigger.ts Show resolved Hide resolved
src/locales/zh_CN/move-trigger.ts Show resolved Hide resolved
Copy link
Contributor

@mercurius-00 mercurius-00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete trailing space

src/locales/de/move-trigger.ts Outdated Show resolved Hide resolved
EnochG1 and others added 3 commits August 1, 2024 19:25
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
Copy link
Contributor

@Adri1 Adri1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added French

src/locales/fr/move-trigger.ts Outdated Show resolved Hide resolved
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Copy link
Contributor

@NicusPulcis NicusPulcis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

italian localization

src/locales/it/move-trigger.ts Outdated Show resolved Hide resolved
Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>
@EnochG1 EnochG1 force-pushed the localization/move-trigger-missed branch from 60a951b to 7d92fbf Compare August 2, 2024 01:05
@EnochG1
Copy link
Contributor Author

EnochG1 commented Aug 2, 2024

@CodeTappert
I reverted your suggestion of move.ts because target is null.
I realized the timing of the setting message is when pokemon used healing wish, not when changed pokemon go out.

image

So please modify your message to match the subject.

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
@Tempo-anon Tempo-anon merged commit ec27c14 into pagefaultgames:beta Aug 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Provides or updates translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants