-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Localization] add missed move trigger and remove getPokemonMessage #3281
[Localization] add missed move trigger and remove getPokemonMessage #3281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zh-CN and zh-TW
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(zh-CN, zh-TW)
change sacrificialFullRestore to match original game text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete trailing space
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added French
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
italian localization
Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>
60a951b
to
7d92fbf
Compare
This reverts commit 4dd6130.
@CodeTappert So please modify your message to match the subject. |
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
What are the changes?
Add the option to localize message texts of some move-trigger which are not localized.
list of messages & poke corpus message key (Just refer it, message can be different with og game.)
healHp : sv.btl_set.BTL_STRID_SET_HP_Recover)
sacrificialFullRestore (subject is different with pokerogue) : sv.btl_set.BTL_STRID_SET_IyasiNoNegai
invertStats : sv.btl_set.BTL_STRID_SET_Hikkurikaesu
resetStats : sv.btl_std.BTL_STRID_STD_RankReset
faintCountdown : sv.btl_std.BTL_STRID_STD_HorobiNoSango
copyType : swsh.btl_set.BTL_STRID_SET_MirrorType
suppressAbilities : sv.btl_set.BTL_STRID_SET_Ieki
swapArenaTags : sv.btl_set.BTL_STRID_SET_CourtChange
Why am I doing these changes?
All text should be localizable.
What did change?
Screenshots/Videos
En
Click to expand/collapse
It
Click to expand/collapse
Fr
Click to expand/collapse
De
Click to expand/collapse
Zh_CN
Click to expand/collapse
Zh_TW
Click to expand/collapse
Ko
Click to expand/collapse
How to test the changes?
Manually (with src/overrides.ts)
List of test-able moves
healHp
sacrificialFullRestore
invertStats
resetStats
faintCountdown
copyType
suppressAbilities
swapArenaTags
Checklist
beta
as my base branchnpm run test
)