Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sprite] Add female Ursaring variant palettes #3282

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

chaosgrimmon
Copy link
Collaborator

What are the changes?

Previously, female Ursaring did not have variant palettes, and so showed up as the standard base shiny. This PR adds the palettes, allowing the intended shiny colours.

Why am I doing these changes?

Reported here, as causing issues on Ydarissep's dex.

What did change?

Added the front and back palette .jsons. Also added the necessary entries to \variant\_masterlist.json for the game to recognise those palettes.

Screenshots/Videos

Before

image

After

image
image
image
image

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
    - [] Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Madmadness65 Madmadness65 added the Sprite/Animation For when graphics are incorrect label Aug 1, 2024
@Tempo-anon Tempo-anon merged commit b0f8f0e into pagefaultgames:beta Aug 1, 2024
4 checks passed
@chaosgrimmon chaosgrimmon deleted the fem-ursaring branch August 29, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprite/Animation For when graphics are incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants