Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Sprite] Wo-Chien back sprite #3307

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

pom-eranian
Copy link
Collaborator

What are the changes?

  • Reworked back exp with less pronounced movement.
  • Fixed antlers stray pixels
  • Png files have less sprites.
  • JSON files and sprite framing are identical between default and shiny.

Why am I doing these changes?

Antlers stray pixels:
[BUG] Black Pixels appear over Wo-Chien back sprite during battle

Anim rework:
Normally I would only have corrected the antlers, but the exp moved like an accordion and I couldn't just send it back into the wild like that. The change is still small enough that it shouldn't be an issue or stand out to players.

Screenshots/Videos

live:
exp_back_1001

This PR:
1001

firefox_2iQy5olspy.mp4

How to test the changes?

src/overrides.ts
Set user species to 1001
set shiny true if testing shiny

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes (manually)?
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

Fixed cropped feet on exp for default & shiny.
Rearranged spritesheet to fit new size.
Both sritesheets have identical sprite framing.
Both json are identical.
cleaned up tips of antlers
slightly improved back sprite
default + shiny. identical json, identical framing
@Tempo-anon Tempo-anon merged commit 03ba575 into pagefaultgames:beta Aug 2, 2024
4 checks passed
@pom-eranian pom-eranian deleted the sprite_wo-chien branch August 2, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants