Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QoL] Auto filtering on challenge mode #3312

Merged

Conversation

KimJeongSun
Copy link
Collaborator

@KimJeongSun KimJeongSun commented Aug 3, 2024

What are the changes?

You no longer need to spend endless time searching for valid Pokémon in the starter select UI during challenge mode.

Why am I doing these changes?

I think this approach is way better. Does anyone disagree?

What did change?

In challenge mode, valid Pokémon will be pre-filtered according to the game mode.
( + The variable name starterContainer could be confusing, so I've corrected it to starterContainers. )

Screenshots/Videos

Screen.Recording.2024-08-03.at.2.54.49.PM.mp4

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@KimJeongSun KimJeongSun marked this pull request as draft August 3, 2024 05:56
@KimJeongSun KimJeongSun marked this pull request as ready for review August 3, 2024 06:02
@DayKev
Copy link
Collaborator

DayKev commented Aug 3, 2024

Looks like it takes into account future/potential eligibility too, nice.

@Madmadness65 Madmadness65 added the Enhancement New feature or request label Aug 3, 2024
@CodeTappert
Copy link
Collaborator

Codewise it looks fine. I will try this out locally

@Tempo-anon Tempo-anon merged commit 800abc4 into pagefaultgames:beta Aug 3, 2024
4 checks passed
@KimJeongSun KimJeongSun deleted the auto-filtering-on-challenge-mode branch August 4, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants