[Bug] Fix blocking menu when 6 starter selected #3333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimJeongSun
changed the title
Tempo-anon
reviewed
Aug 4, 2024
src/ui/starter-select-ui-handler.ts
Outdated
| @@ -1265,7 +1265,7 @@ export default class StarterSelectUiHandler extends MessageUiHandler { | |||
| if (button === Button.ACTION) { | |||
| if (!this.speciesStarterDexEntry?.caughtAttr) { | |||
| error = true; | |||
| } else if (this.starterSpecies.length < 6) { // checks to see you have less than 6 pokemon in your party | |||
| } else if (this.starterSpecies.length <= 6) { // checks to see you have less than 6 pokemon in your party | |||
There was a problem hiding this comment.
This comment no longer matches the logic
There was a problem hiding this comment.
thanks for comment i updated comment
// checks to see if the party has 6 or fewer pokemon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
Fixed an issue where the menu wouldn't open when 6 starter Pokémon were selected.
Why am I doing these changes?
Previously, this issue prevented the removeFromParty action from being performed through the menu when a 6th Pokémon was added.
What did change?
Modified the if condition for opening the menu.
Screenshots/Videos
before ( can't open menu )
after ( can open menu )
How to test the changes?
Checklist
betaas my base branchnpm run test)