Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add filters for pokerus, HA, cost reduction #3343

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

KimJeongSun
Copy link
Collaborator

@KimJeongSun KimJeongSun commented Aug 4, 2024

What are the changes?

Added filters for cost reduction, HA, and Pokérus.

Why am I doing these changes?

I believe these are essential features.

What did change?

Added cost reduction to unlocks and HA and Pokérus filters to misc.
I have added entries for translation on each locales

Screenshots/Videos

Screen.Recording.2024-08-05.at.11.16.30.PM.mp4

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@KimJeongSun KimJeongSun marked this pull request as ready for review August 4, 2024 16:25
@Tempo-anon Tempo-anon added the Enhancement New feature or request label Aug 4, 2024
@torranx
Copy link
Collaborator

torranx commented Aug 5, 2024

Is the video in the description updated? I see some keys there

@KimJeongSun
Copy link
Collaborator Author

KimJeongSun commented Aug 5, 2024

actually, it is recorded before adding default english translation, if you want, i will update it

@KimJeongSun
Copy link
Collaborator Author

KimJeongSun commented Aug 5, 2024

video is updated with initial english translation entries

Copy link
Collaborator

@MokaStitcher MokaStitcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of lines you forgot to delete but other than that everything seems good!

src/ui/starter-select-ui-handler.ts Outdated Show resolved Hide resolved
src/ui/starter-select-ui-handler.ts Outdated Show resolved Hide resolved
KimJeongSun and others added 2 commits August 6, 2024 00:24
Co-authored-by: MokaStitcher <54149968+MokaStitcher@users.noreply.github.com>
Co-authored-by: MokaStitcher <54149968+MokaStitcher@users.noreply.github.com>
@Tempo-anon Tempo-anon merged commit d323817 into pagefaultgames:beta Aug 5, 2024
4 checks passed
@KimJeongSun KimJeongSun deleted the add-filters branch August 5, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants