[Move] Implement (or re-implement?) Lucky Chant #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO before moving out of draft:
|
EnochG1
reviewed
Aug 4, 2024
CodeTappert
reviewed
Aug 5, 2024
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com> Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr> Co-authored-by: Enoch <enoch.jwsong@gmail.com> Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
sonnyding1
reviewed
Aug 6, 2024
Co-authored-by: Sonny Ding <93831983+sonnyding1@users.noreply.github.com>
|
@innerthunder |
Done. Gonna take this out of draft since I've heard some of the translators are busy/on vacation atm, but this is still waiting on ES and IT (and now JA) translations. |
|
IMO you don't have to get all translation. Once you add message key with english text, translators can make new PR :) |
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes?
This fully implements the move Lucky Chant.
Why am I doing these changes?
Lucky Chant is unimplemented... or, at least, it's marked as unimplemented. Before these changes, Lucky Chant used a battler tag to prevent critical hits on the user, but since it was marked (N), its effects were not functional and the move was disabled. Also, just removing the
.unimplemented()flag from the move was insufficient since Lucky Chant is meant to protect both the user and its ally. The changes in this PR bring Lucky Chant to its full functionality.What did change?
data/arena-tagandenums/arena-tag-type: NewNoCritTag(of tag typeArenaTagType.NO_CRIT) prevents hits against the tag's side from dealing critical damage.data/battler-tagsandenums/battler-tag-type: RemovedBattlerTagType.NO_CRIT, a part of Lucky Chant's previous partial implementation.data/move: Updated Lucky Chant:.unimplemented()flagAddBattlerTagAttrtoAddArenaTagAttrwith the newNO_CRITarena tag.field/pokemon: Minor changes reflecting changes toNO_CRITtag implementation.test/moves/lucky_chant.test: New integration test for Lucky Chant's effects in single and double battlestest/moves/dragon_rage.test: Fixed a test that used theNO_CRITtag incorrectly.Screenshots/Videos
PokeRogueTest-LuckyChant.mp4
How to test the changes?
npm run test lucky_chantChecklist
betaas my base branchnpm run test)