Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Balance] "Old Yeller" White Herb #3366

Merged
merged 3 commits into from
Aug 6, 2024
Merged

[Balance] "Old Yeller" White Herb #3366

merged 3 commits into from
Aug 6, 2024

Conversation

Fontbane
Copy link
Contributor

@Fontbane Fontbane commented Aug 5, 2024

What are the changes?

  • Look at the rabbits, White Herb...

Why am I doing these changes?

  • The People were not ready

What did change?

  • Offered compassionate care to the White Herb item

Screenshots/Videos

image

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Madmadness65 Madmadness65 added Item Affects an item Balance Team Specifically a balance team change labels Aug 5, 2024
@damocleas damocleas added the Game Balance Changes that heavily impact the game label Aug 5, 2024
@Tempo-anon
Copy link
Collaborator

Instead of commenting out all that code why not just set the weight to 0

@Fontbane
Copy link
Contributor Author

Fontbane commented Aug 6, 2024

Instead of commenting out all that code why not just set the weight to 0

ok

@Tempo-anon Tempo-anon merged commit 1711b6c into pagefaultgames:beta Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damocleas damocleas damocleas approved these changes

Assignees
No one assigned
Labels
Balance Team Specifically a balance team change Game Balance Changes that heavily impact the game Item Affects an item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fontbane @Tempo-anon @damocleas @Madmadness65