-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Named Evil Team Admins #3384
Conversation
…3' into evilTeamAdmins
TODO: Dialogue |
public/images/trainer/bryony.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why Rocket has all 4 admins while Flare only has 2 when Aliana, Celosia, and Mable also exist? I do think that Bryony is the most iconic one though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not have found sprites for the other flare admins.
If you have them i can add them
@@ -1,215 +1,223 @@ | |||
|
|||
export enum TrainerType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of formatting changes in this file. Is that necessary or some new standard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No clue. Lint says its fine. It doesnt show an error on the padding
…evil team leaders, gym leaders, elite 4 and champions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Korean translation (still many lines to be translated)
src/data/trainer-config.ts
Outdated
[TrainerPoolTier.RARE]: [Species.DRUDDIGON, Species.BOUFFALANT, Species.AXEW, Species.DEINO, Species.DURANT] | ||
}; | ||
} | ||
case "colress": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I think it's a bit weird to have a completely separate pokemon pool for two different admins. Especially since now there's a 2/3 Zinzolin and Rood pull from one pool and Colress pulls from another. If Colress is so mechanically and thematically unique he should be his own encounter somewhere else and not be part of the admins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Ask the leads for a decision on that. I am fine with removing colress as a admin for now
@CodeTappert |
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr> Co-authored-by: returntoice <dieandbecome@gmail.com>
done |
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
What are the changes?
The genereic evil Team Admins are changed to have actual names and different sprites, they all get one signature pokemon. The rest stays the same
Why am I doing these changes?
Because this gives more "feel" to the game.
What did change?
New Trainer Classes (they dont give vouchers), new method for evil teams, new dialogue etc
Screenshots/Videos
2024-08-06.19-24-29.mp4
2024-08-06.19-25-10.mp4
2024-08-06.19-25-36.mp4
2024-08-06.19-25-54.mp4
2024-08-06.19-26-09.mp4
2024-08-06.19-26-27.mp4
2024-08-06.19-26-41.mp4
2024-08-06.19-27-30.mp4
2024-08-06.19-27-49.mp4
2024-08-06.19-28-06.mp4
2024-08-06.19-28-36.mp4
2024-08-06.19-28-56.mp4
2024-08-06.19-29-10.mp4
2024-08-06.19-29-25.mp4
How to test the changes?
Force Spawn them or hit a wave the generic ones would spawn on
Checklist
beta
as my base branchnpm run test
)