Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Named Evil Team Admins #3384

Merged
merged 52 commits into from
Aug 7, 2024

Conversation

CodeTappert
Copy link
Collaborator

@CodeTappert CodeTappert commented Aug 6, 2024

What are the changes?

The genereic evil Team Admins are changed to have actual names and different sprites, they all get one signature pokemon. The rest stays the same

Why am I doing these changes?

Because this gives more "feel" to the game.

What did change?

New Trainer Classes (they dont give vouchers), new method for evil teams, new dialogue etc

Screenshots/Videos

2024-08-06.19-24-29.mp4
2024-08-06.19-25-10.mp4
2024-08-06.19-25-36.mp4
2024-08-06.19-25-54.mp4
2024-08-06.19-26-09.mp4
2024-08-06.19-26-27.mp4
2024-08-06.19-26-41.mp4
2024-08-06.19-27-30.mp4
2024-08-06.19-27-49.mp4
2024-08-06.19-28-06.mp4
2024-08-06.19-28-36.mp4
2024-08-06.19-28-56.mp4
2024-08-06.19-29-10.mp4
2024-08-06.19-29-25.mp4

How to test the changes?

Force Spawn them or hit a wave the generic ones would spawn on

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@CodeTappert
Copy link
Collaborator Author

TODO: Dialogue

src/battle.ts Outdated Show resolved Hide resolved
src/battle.ts Outdated Show resolved Hide resolved
src/battle.ts Outdated Show resolved Hide resolved
src/battle.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why Rocket has all 4 admins while Flare only has 2 when Aliana, Celosia, and Mable also exist? I do think that Bryony is the most iconic one though

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not have found sprites for the other flare admins.
If you have them i can add them

@@ -1,215 +1,223 @@

export enum TrainerType {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of formatting changes in this file. Is that necessary or some new standard?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue. Lint says its fine. It doesnt show an error on the padding

src/data/trainer-config.ts Outdated Show resolved Hide resolved
src/data/trainer-config.ts Outdated Show resolved Hide resolved
src/data/trainer-config.ts Outdated Show resolved Hide resolved
src/data/trainer-config.ts Outdated Show resolved Hide resolved
src/locales/fr/trainers.ts Outdated Show resolved Hide resolved
src/locales/fr/trainers.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@returntoice returntoice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Korean translation (still many lines to be translated)

src/locales/ko/trainers.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
src/locales/ko/dialogue.ts Outdated Show resolved Hide resolved
[TrainerPoolTier.RARE]: [Species.DRUDDIGON, Species.BOUFFALANT, Species.AXEW, Species.DEINO, Species.DURANT]
};
}
case "colress": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I think it's a bit weird to have a completely separate pokemon pool for two different admins. Especially since now there's a 2/3 Zinzolin and Rood pull from one pool and Colress pulls from another. If Colress is so mechanically and thematically unique he should be his own encounter somewhere else and not be part of the admins

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Ask the leads for a decision on that. I am fine with removing colress as a admin for now

@EnochG1
Copy link
Contributor

EnochG1 commented Aug 7, 2024

@CodeTappert
From now Japanese is added in beta.
Please merge latest beta and add Japanese locale files 🙏

CodeTappert and others added 3 commits August 7, 2024 09:21
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: returntoice <dieandbecome@gmail.com>
@CodeTappert
Copy link
Collaborator Author

@CodeTappert From now Japanese is added in beta. Please merge latest beta and add Japanese locale files 🙏

done

@Tempo-anon Tempo-anon merged commit 60d19c9 into pagefaultgames:beta Aug 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Localization Provides or updates translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants