[Bug] Fixes Moveset Flyout not updating PP from Spite PP reduction #3388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebranch of #3132
What are the changes?
#2347
Fixes the visual bug with the Moveset Flyout not updating on Spite reductions.
Why am I doing these changes?
It is a visual bug.
What did change?
Removed the calculation done within the
BattleFlyout
class. Instead, I send the move's current pp value instead of the pp being used for that turn.Dispatches a MoveUsedEvent in Spite with the newly reduced pp value.
Screenshots/Videos
Before
Before.flyout.fix.mp4
After
After.spite.flyout.fix.mp4
How to test the changes?
Give yourself Spite with src/overrides.ts, test against opponent's moves while checking the battle flyout using V button.
Checklist
beta
as my base branchnpm run test
)