Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fixes Moveset Flyout not updating PP from Spite PP reduction #3388

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

schmidtc1
Copy link
Contributor

@schmidtc1 schmidtc1 commented Aug 6, 2024

Rebranch of #3132

What are the changes?

#2347
Fixes the visual bug with the Moveset Flyout not updating on Spite reductions.

Why am I doing these changes?

It is a visual bug.

What did change?

Removed the calculation done within the BattleFlyout class. Instead, I send the move's current pp value instead of the pp being used for that turn.
Dispatches a MoveUsedEvent in Spite with the newly reduced pp value.

Screenshots/Videos

Before

Before.flyout.fix.mp4

After

After.spite.flyout.fix.mp4

How to test the changes?

Give yourself Spite with src/overrides.ts, test against opponent's moves while checking the battle flyout using V button.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@schmidtc1 schmidtc1 marked this pull request as ready for review August 6, 2024 20:44
@Tempo-anon Tempo-anon added (Legacy) Bug Legacy Label, don't apply to new issues/PRs Move Affects a move labels Aug 6, 2024
@Tempo-anon Tempo-anon merged commit da51d6a into pagefaultgames:beta Aug 6, 2024
4 checks passed
@schmidtc1 schmidtc1 deleted the spiteflyoutbug2 branch August 6, 2024 21:02
@Snailman11
Copy link
Collaborator

Link to Discord's bug report (Bug with spite?)
https://discord.com/channels/1125469663833370665/1251572931964829709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Legacy) Bug Legacy Label, don't apply to new issues/PRs Move Affects a move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants