Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Moves copied by Dancer should not consume PP #3623

Merged
merged 8 commits into from
Sep 2, 2024

Conversation

DayKev
Copy link
Collaborator

@DayKev DayKev commented Aug 18, 2024

What are the changes the user will see?

Dancer will no longer use PP when triggered.

Why am I making these changes?

Dancer is not supposed to consume PP.

What are the changes from a developer perspective?

The ignorePP parameter is passed as true to the MovePhase created by the Dancer ability, and the ignorePP parameter is made to actually function in MovePhase:start().domove().

How to test the changes?

Override the battle type to doubles, have a team of Oricorio + another Pokémon and add Swords Dance via the moves override. Use Swords Dance with the non-Oricorio Pokémon and have Oricorio use a different move. Example:

const overrides = {
  MOVESET_OVERRIDE: [Moves.SPLASH, Moves.SWORDS_DANCE],
  OPP_SPECIES_OVERRIDE: Species.MAGIKARP,
  OPP_MOVESET_OVERRIDE: Array(4).fill(Moves.SPLASH),
  BATTLE_TYPE_OVERRIDE: "double"
} satisfies Partial<InstanceType<typeof DefaultOverrides>>;

Screenshots/Videos

Before fix:

dancer.bug.mp4

After fix:

dancer.fix.mp4

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • [ ] If I have text, did I add placeholders for them in locales?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [ ] Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@DayKev DayKev added the (Legacy) Bug Legacy Label, don't apply to new issues/PRs label Aug 18, 2024
@Snailman11
Copy link
Collaborator

Link to Discord's bug report https://discord.com/channels/1125469663833370665/1274672573556330526 (Dancer Ability fails if the move it copied is at 0pp)

Copy link
Collaborator

@frutescens frutescens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a unit test for Dancer?

@frutescens
Copy link
Collaborator

HI! could you resolve the merge conflicts?

@DayKev DayKev requested a review from a team as a code owner August 31, 2024 09:35
This test is not finished lol
@DayKev DayKev marked this pull request as draft August 31, 2024 09:37
@DayKev DayKev marked this pull request as ready for review September 1, 2024 01:36
@DayKev DayKev added Ability Affects an ability P2 Bug Minor. Non crashing Incorrect move/ability/interaction labels Sep 1, 2024
@Tempo-anon Tempo-anon merged commit 69a9916 into pagefaultgames:beta Sep 2, 2024
4 checks passed
@DayKev DayKev deleted the fix-dancer branch September 2, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability (Legacy) Bug Legacy Label, don't apply to new issues/PRs P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants