Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Tests now default to using "Set" battle style #3728

Merged
merged 6 commits into from
Sep 2, 2024

Conversation

DayKev
Copy link
Collaborator

@DayKev DayKev commented Aug 24, 2024

What are the changes the user will see?

N/A

Why am I making these changes?

Make it easier to write tests.

What are the changes from a developer perspective?

By default, all tests now run in "set" battle style rather than "switch". This can be changed via game.settings.battleStyle = BattleStyle.SWITCH;

How to test the changes?

npm run test

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • [ ] Have I considered writing automated tests for the issue?
  • [ ] If I have text, did I add placeholders for them in locales?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [ ] Are the changes visual?
    • [ ] Have I provided screenshots/videos of the changes?

@DayKev DayKev added Tests Automated tests related Refactor Rewriting existing code related labels Aug 24, 2024
torranx
torranx previously approved these changes Aug 24, 2024
@DayKev DayKev requested a review from a team as a code owner August 28, 2024 19:51
Copy link
Collaborator

@Tempo-anon Tempo-anon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No user facing changes :snoremax:

@Tempo-anon Tempo-anon merged commit 1fd6621 into pagefaultgames:beta Sep 2, 2024
4 checks passed
@DayKev DayKev deleted the tests-use-set-style branch September 2, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Rewriting existing code related Tests Automated tests related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants