Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add font size option per language on registration UI #3849

Merged

Conversation

KimJeongSun
Copy link
Collaborator

@KimJeongSun KimJeongSun commented Aug 27, 2024

What are the changes the user will see?

Spanish-language users will see a more polished and organized register menu screen.

Why am I making these changes?

There was a request from @AsdarDevelops to make these changes!

What are the changes from a developer perspective?

I modified registration-form-ui-handler.ts to allow font settings for each language.

Screenshots/Videos

  • before
    image

  • after

image

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@KimJeongSun KimJeongSun marked this pull request as ready for review August 27, 2024 15:59
@KimJeongSun KimJeongSun requested a review from a team as a code owner August 27, 2024 15:59
@KimJeongSun
Copy link
Collaborator Author

@flx-sta

Actually, while working on the above changes, I also planned to organize the German version. However, the problem with the German version is that the button sizes need to be adjusted as well.

Below is a screenshot where I only adjusted the button labels’ size: (related commit)
Screenshot 2024-08-28 at 12 46 34 AM

As you can see, in my previous attempt, the button sizes didn't reduce properly.

If possible, adding this feature might make it more flexible and better. Additionally, you can consider refactoring my code by inheriting classes, if possible! (It was a bit too much for me)

Of course, if it’s not possible to work on this immediately, we can proceed as is and add further developments later.

@CodeTappert
Copy link
Collaborator

Please also for german. I think the text is too big there too

@KimJeongSun
Copy link
Collaborator Author

@flx-sta 🙏

@KimJeongSun KimJeongSun marked this pull request as draft August 27, 2024 16:21
@KimJeongSun KimJeongSun marked this pull request as ready for review August 27, 2024 16:30
src/ui/registration-form-ui-handler.ts Outdated Show resolved Hide resolved
src/ui/registration-form-ui-handler.ts Outdated Show resolved Hide resolved
src/ui/registration-form-ui-handler.ts Outdated Show resolved Hide resolved
src/ui/registration-form-ui-handler.ts Outdated Show resolved Hide resolved
src/ui/registration-form-ui-handler.ts Show resolved Hide resolved
@KimJeongSun KimJeongSun requested a review from a team as a code owner August 28, 2024 07:55
@KimJeongSun
Copy link
Collaborator Author

@flx-sta
can you make new PR to beta ( or PR toward this PR ) for DE updates? ( including resize button size + button label font size )?

@Madmadness65 Madmadness65 added the Enhancement New feature or request label Aug 29, 2024
@f-fsantos f-fsantos added the Localization Provides or updates translation efforts label Aug 29, 2024
Copy link
Collaborator

@AsdarDevelops AsdarDevelops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much

src/locales/es/menu.json Outdated Show resolved Hide resolved
src/ui/registration-form-ui-handler.ts Outdated Show resolved Hide resolved
@DayKev DayKev dismissed f-fsantos’s stale review September 2, 2024 05:55

requested change applied

@f-fsantos f-fsantos added this pull request to the merge queue Sep 5, 2024
Merged via the queue into pagefaultgames:beta with commit 1968680 Sep 5, 2024
4 checks passed
@KimJeongSun KimJeongSun deleted the support-font-size-on-register-UI branch September 11, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Localization Provides or updates translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants