Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ability] Implement Tera Shell #3856

Merged
merged 8 commits into from
Sep 2, 2024

Conversation

innerthunder
Copy link
Collaborator

What are the changes the user will see?

This implements the ability Tera Shell

Why am I making these changes?

Tera Shell is unimplemented, and my rewrite to Pokemon#getMoveEffectiveness (#3704) made it very easy to implement.

What are the changes from a developer perspective?

  • data/ability: New pre-defend attribute FullHpResistTypeAbAttr changes the input type multiplier to 0.5 if it isn't already 0.5 or lower.
  • field/pokemon: getMoveEffectiveness now applies FullHpResistTypeAbAttr as the last step (if the move is an attack).
  • test/abilities/tera_shell.test New integration test suite for Tera Shell's effects on type effectiveness.

Screenshots/Videos

PokeRogue.-.Google.Chrome.2024-08-27.15-32-01.mp4

How to test the changes?

npm run test tera_blast

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@innerthunder innerthunder requested review from a team as code owners August 27, 2024 22:47
@innerthunder innerthunder changed the title [Move] Implement Tera Shell [Ability] Implement Tera Shell Aug 27, 2024
@innerthunder innerthunder added the Ability Affects an ability label Aug 27, 2024
src/test/abilities/tera_shell.test.ts Outdated Show resolved Hide resolved
src/test/abilities/tera_shell.test.ts Outdated Show resolved Hide resolved
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
@innerthunder innerthunder requested a review from a team August 28, 2024 00:33
DayKev
DayKev previously approved these changes Aug 28, 2024
src/data/ability.ts Outdated Show resolved Hide resolved
src/data/ability.ts Show resolved Hide resolved
src/data/ability.ts Show resolved Hide resolved
src/test/abilities/tera_shell.test.ts Show resolved Hide resolved
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
src/data/ability.ts Show resolved Hide resolved
Copy link
Collaborator

@frutescens frutescens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@DayKev
Copy link
Collaborator

DayKev commented Sep 2, 2024

TIL 4 < 3
image

@f-fsantos f-fsantos merged commit 7755f79 into pagefaultgames:beta Sep 2, 2024
4 checks passed
@SangaraSorama SangaraSorama added the Localization Provides or updates translation efforts label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability Localization Provides or updates translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants