-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ability] Implement Tera Shell #3856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innerthunder
changed the title
[Move] Implement Tera Shell
[Ability] Implement Tera Shell
Aug 27, 2024
82 tasks
DayKev
reviewed
Aug 27, 2024
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
DayKev
previously approved these changes
Aug 28, 2024
torranx
reviewed
Aug 30, 2024
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
torranx
approved these changes
Aug 31, 2024
Tempo-anon
approved these changes
Aug 31, 2024
frutescens
approved these changes
Sep 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DayKev
approved these changes
Sep 2, 2024
f-fsantos
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
This implements the ability Tera Shell
Why am I making these changes?
Tera Shell is unimplemented, and my rewrite to
Pokemon#getMoveEffectiveness
(#3704) made it very easy to implement.What are the changes from a developer perspective?
data/ability
: New pre-defend attributeFullHpResistTypeAbAttr
changes the input type multiplier to 0.5 if it isn't already 0.5 or lower.field/pokemon
:getMoveEffectiveness
now appliesFullHpResistTypeAbAttr
as the last step (if the move is an attack).test/abilities/tera_shell.test
New integration test suite for Tera Shell's effects on type effectiveness.Screenshots/Videos
PokeRogue.-.Google.Chrome.2024-08-27.15-32-01.mp4
How to test the changes?
npm run test tera_blast
Checklist
beta
as my base branchnpm run test
)