Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Roark Dialouge #3873

Merged
merged 11 commits into from
Sep 2, 2024
Merged

Fix Roark Dialouge #3873

merged 11 commits into from
Sep 2, 2024

Conversation

gitlocalize-app[bot]
Copy link
Contributor

@gitlocalize-app gitlocalize-app bot commented Aug 28, 2024

What are the changes the user will see?

A new Dialouge line for when encountering roark

Why am I making these changes?

Because he had the same line twice

What are the changes from a developer perspective?

i also removed one victory message (was never shown since he only has 4 encounter ones anyways)
also changed the defeat messages, but those are also never shown so no change for the player there

Screenshots/Videos

See the comment below

How to test the changes?

Spawn him and see it

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
    • Well i could have done seperat prs for german and english but well...I didnt. Hope its ok
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@gitlocalize-app gitlocalize-app bot requested a review from a team as a code owner August 28, 2024 19:25
@CodeTappert
Copy link
Collaborator

CodeTappert commented Aug 28, 2024

DE new enouncter:

Aufzeichnung.2024-08-28.213230.mp4

EN New encounter:

Aufzeichnung.2024-08-28.221327.mp4

@CodeTappert CodeTappert marked this pull request as draft August 28, 2024 19:50
@CodeTappert CodeTappert changed the title [Localization] [DE] Double Roark Dialouge Fix Roark Dialouge Aug 28, 2024
@AsdarDevelops
Copy link
Collaborator

Please also remove Roark's duplicate "victorial line" from Morty's dialogues while you're at it.

image
image

@CodeTappert
Copy link
Collaborator

Please also remove Roark's duplicate "victorial line" from Morty's dialogues while you're at it.

image image

Roark does not have this line anymore

@CodeTappert CodeTappert marked this pull request as ready for review August 28, 2024 20:20
@CodeTappert CodeTappert requested a review from a team as a code owner August 28, 2024 20:20
@Madmadness65 Madmadness65 added the Miscellaneous Changes that don't fit under any other label label Aug 29, 2024
Tempo-anon
Tempo-anon previously approved these changes Aug 29, 2024
@Tempo-anon Tempo-anon merged commit 8082835 into beta Sep 2, 2024
5 checks passed
@gitlocalize-app gitlocalize-app bot deleted the gitlocalize-30764 branch September 2, 2024 03:28
@SangaraSorama SangaraSorama added the Localization Provides or updates translation efforts label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Provides or updates translation efforts Miscellaneous Changes that don't fit under any other label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants