Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] [QoL] [Enhancement] Exclude redundant species from certain filters in starter select #3910

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

Fontbane
Copy link
Contributor

@Fontbane Fontbane commented Aug 30, 2024

What are the changes the user will see?

  • In the starter select UI, when filtering for mons you don't have the hidden ability of, mons who don't have an HA at all will be excluded
  • When filtering for mons you don't have passive or any cost reduction unlocked for yet, starters who don't have candy (Pikachu et al) will be excluded

Why am I making these changes?

  • The "Hidden Ability- No" option is useful for seeing which mons you haven't found the hidden ability of
  • It's redundant and possibly misleading to show the player mons with nonexistent hidden abilities alongside mons with hidden abilities the player just hasn't found
  • Same applies even moreso to passives and cost reductions
  • This makes the filters more useful for giving an overview of goals for the player

What are the changes from a developer perspective?

  • Adds a speciesHasHiddenAbility check for the HA filter
  • The condition for the exclude state now requires speciesHasHiddenAbility to be true as well as it not being unlocked
  • Adds a isStarterProgressable check for a few other filters, whether that starter gets candy/egg moves/etc
  • Adds an enum SortCriteria in dropdown.ts for the criteria by which the player can sort the starters

Screenshots/Videos

Before:
Screenshot_868
Note the presence of Mew, which does not have a Hidden Ability at all.

After:
image
Note the absence of Mew between Mewtwo and Cyndaquil, as well as the rows starting with Drowzee appearing to have shifted one slot- Gastly has no hidden ability (unless #1845 is reconsidered), so Onix takes its place on that row and everything else shifts to the left.

Before:
Screenshot_871
Note that many starters without candy, such as the Hitmons, Chansey, Snorlax etc. are shown

After:
Screenshot_869
Bye bye

Before:
Screenshot_872
Same as passive

After:
Screenshot_870

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Fontbane Fontbane requested a review from a team as a code owner August 30, 2024 01:47
src/ui/starter-select-ui-handler.ts Outdated Show resolved Hide resolved
@DayKev DayKev dismissed flx-sta’s stale review August 30, 2024 02:06

Fixed the imports

DayKev
DayKev previously approved these changes Aug 30, 2024
@flx-sta flx-sta added the Enhancement New feature or request label Aug 30, 2024
@Fontbane Fontbane changed the title [QoL] [Enhancement] Exclude species without HA from HA filters in starter select [QoL] [Enhancement] Exclude redundant species from certain filters in starter select Aug 30, 2024
@DayKev DayKev added the UI/UX User interface/-experience related label Aug 30, 2024
Copy link
Collaborator

@KimJeongSun KimJeongSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flx-sta flx-sta added the Refactor Rewriting existing code related label Aug 30, 2024
@Fontbane Fontbane changed the title [QoL] [Enhancement] Exclude redundant species from certain filters in starter select [UI] [QoL] [Enhancement] Exclude redundant species from certain filters in starter select Sep 1, 2024
@frutescens frutescens merged commit 335d32e into pagefaultgames:beta Sep 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Refactor Rewriting existing code related UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants