[Ability] Add form change support for Flower Gift

[torranx]

What are the changes the user will see?

Cherrim should now transform during Harsh Sunlight similar to Castform

Why am I making these changes?

Cherrim does not transform on Harsh Sunlight

What are the changes from a developer perspective?

Added form change conditions - attached to what Forecast is using

Screenshots/Videos

How to test the changes?

Use Cherrim and set weather to Harsh Sunlight/Sunny

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• If I have text, did I make it translatable and add a key in the English locale file(s)?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[Tempo-anon]

Wasn't around for when the Forecast PR got merged in but I assume it also works with all the misc edge cases such as weather being suppressed and then no longer being suppressed? If so then this looks good to me, just some personal style nits

[torranx]

Wasn't around for when the Forecast PR got merged in but I assume it also works with all the misc edge cases such as weather being suppressed and then no longer being suppressed? If so then this looks good to me, just some personal style nits

Yes, pesky Air Lock/Cloud Nine - but one edge case is noted on the Forecast PR description (which does have already at least 2 PRs trying to fix it rn)

TLDR: if enemy with air lock/cloud nine didnt receive any attacks and fainted, post faint ability attrs do not proc - hence form change not happening, this is bypassed by PreSwitchOut ab attrs for the player & enemy trainer tho

[DayKev]

Well, if Cherubi evolves into Cherrim, then it won't form-change if the weather is currently sunny when it evolves. Dunno if we care about this edge case.

[torranx]

Well, if Cherubi evolves into Cherrim, then it won't form-change if the weather is currently sunny when it evolves. Dunno if we care about this edge case.

Yeah this is an unaccounted edge case but I'll leave this as is for now since we currently don't have a system for post evolution.