[Hotfix][Bug] Unneeded RNG calls

[frutescens]

What are the changes the user will see?

RNG will be unaffected by accessing save-slot-select UI, run history UI, or run-info UI.

Why am I making these changes?

Bug Report: https://discord.com/channels/1125469663833370665/1279928555186290698/1280005345321816136

What are the changes from a developer perspective?

The RNG calls have been moved until after the Pokemon has been checked for an ability index. Because the PokemonData involved in these UIs already have an ability index, the RNG calls will not be called. This will not affect Pokemon generation for battle.

Screenshots/Videos

Will upload a run tomorrow morning. Sorry, very tired. Feel free to test though.

How to test the changes?

Start and play a wave (do not complete) --> Save and Quit --> Open Run History/Load Save/Run Info --> Go back to the wave and repeat the same actions.
The second playthrough should be identical in results to the first playthrough.

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[Tempo-anon]

How was this not caught earlier :plains: