[Bug] Ineligible Pokemon will not contribute to luck in a challenge

[frutescens]

What are the changes the user will see?

Ineligible Pokemon will not contribute to luck in a challenge.

Why am I making these changes?

Against game design.
Issue #3955

What are the changes from a developer perspective?

The conditional used in getPartyLuckValue() to filter eligible Pokemon has been changed from p.isFainted() to p.isAllowedInBattle() --> which also checks if the Pokemon is fainted.
The ternary has also been reversed for readability to the below.
p.isAllowedInBattle() ? p.getLuckValue : 0

Screenshots/Videos

Video #1 : MonoGen 3 -> numerous shiny ineligible Pokemon were caught with no change to luck

freecompress-Screen.Recording.2024-09-02.at.11.18.14.AM.mp4

Video #2 : MonoGen 1 --> eligible shiny Weedle caught (Luck up!) + ineligible shiny Bidoof caught (No change to Luck)

freecompress-Screen.Recording.2024-09-02.at.11.20.55.AM.mp4

How to test the changes?

Be lucky like me.

Or use the overrides to guarantee shinies and start a species-restrictive challenge.

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?