Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Clean up the Battle class a bit #3995

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

DayKev
Copy link
Collaborator

@DayKev DayKev commented Sep 3, 2024

What are the changes the user will see?

N/A

Why am I making these changes?

General code cleanup.

What are the changes from a developer perspective?

Various instances of public var; this.var = 0; turned into public var = 0;
An instance of !! was replaced with ?? false
A couple of comments were made into tsdoc comments.

How to test the changes?

npm run test

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • [ ] Have I considered writing automated tests for the issue?
  • [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [ ] Are the changes visual?
    • [ ] Have I provided screenshots/videos of the changes?

Turn a couple of comments into tsdoc comments

Replace a `!!` with `?? false`
@DayKev DayKev added Miscellaneous Changes that don't fit under any other label Refactor Rewriting existing code related labels Sep 3, 2024
@DayKev DayKev requested a review from a team as a code owner September 3, 2024 05:56
@torranx
Copy link
Collaborator

torranx commented Sep 4, 2024

while you're at it, can you please change the integer types to number?

@DayKev
Copy link
Collaborator Author

DayKev commented Sep 4, 2024

Good point.

@Tempo-anon Tempo-anon added this pull request to the merge queue Sep 5, 2024
Merged via the queue into pagefaultgames:beta with commit 237aad2 Sep 5, 2024
4 checks passed
@DayKev DayKev deleted the minor-battle_ts-refactor branch September 5, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Miscellaneous Changes that don't fit under any other label Refactor Rewriting existing code related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants