[Test] Add Dragon Cheer tests

[torranx]

What are the changes the user will see?

none

Why am I making these changes?

adding tests to #3959 now that it is possible

What are the changes from a developer perspective?

dragon cheer test

Screenshots/Videos

How to test the changes?

npm run test dragon_cheer

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• If I have text, did I make it translatable and add a key in the English locale file(s)?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[flx-sta]

I know tests are sometimes redundant but some of those seem like they could be merged. especially the first few lines are almost identical and could be put into beforeEach() while exposting the properly variables in the correct scope (of describe)

[torranx]

I know tests are sometimes redundant but some of those seem like they could be merged. especially the first few lines are almost identical and could be put into beforeEach() while exposting the properly variables in the correct scope (of describe)

when you say "first few lines", I'm assuming these:

await game.classicMode.startBattle([Species.DRAGONAIR, Species.MAGIKARP]);

const magikarp = game.scene.getPlayerField()[1];
const enemy = game.scene.getEnemyField()[0];

vi.spyOn(enemy, "getCritStage");

game.move.select(Moves.DRAGON_CHEER, 0);
game.move.select(Moves.TACKLE, 1, BattlerIndex.ENEMY);

you cant get the pokemon without starting the battle first

[flx-sta]

@torranx I mean you can start the battle in beforeEach() too. That's what I meant

[torranx]

@torranx I mean you can start the battle in beforeEach() too. That's what I meant

that would require setting the beforeEach()'s callback to be async, will that not cause side effects?