Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P3 Bug] Fixed mbh not using the user's nickname #4033

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Tempo-anon
Copy link
Collaborator

@Tempo-anon Tempo-anon commented Sep 5, 2024

What are the changes the user will see?

mbh activation message will now show the user's nickname

Why am I making these changes?

Consistency. Also closes #4030

What are the changes from a developer perspective?

changed pokemon.name to pokemon.getNameToRender()

Screenshots/Videos

How to test the changes?

readonly STARTING_HELD_ITEMS_OVERRIDE: ModifierOverride[] = [{name: "MINI_BLACK_HOLE", count: 1}];
readonly OPP_HELD_ITEMS_OVERRIDE: ModifierOverride[] = [{name: "LUCKY_EGG", count: 99}];

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Tempo-anon Tempo-anon added the P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. label Sep 5, 2024
@Tempo-anon Tempo-anon requested a review from a team as a code owner September 5, 2024 02:07
Copy link
Collaborator

@flx-sta flx-sta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tempo-anon Technically you are missing automated tests.........


Before

⏯️ Video
Screen.Recording.2024-09-04.at.8.41.14.PM.mov

After

Screen.Recording.2024-09-04.at.8.42.36.PM.mov

@torranx torranx added this pull request to the merge queue Sep 5, 2024
Merged via the queue into pagefaultgames:beta with commit 8342554 Sep 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Mini Black Hole Does not Display Holder's Nickname, uses Species Instead
4 participants