Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc][Move] Remove partial tag from Tera Blast #4044

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

torranx
Copy link
Collaborator

@torranx torranx commented Sep 5, 2024

What are the changes the user will see?

No functional change, this just removes the (P) tag from Tera Blast

Why am I making these changes?

Tera Blast is marked as partial because of "the lack of Stellar offense typing implementation in the typings", but it already WORKS with stellar types - it's just that it is not yet obtainable in-game it is obtainable in-game

What are the changes from a developer perspective?

removed partial() from tera blast

Screenshots/Videos

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@torranx torranx requested a review from a team as a code owner September 5, 2024 08:04
@torranx torranx changed the title [Move] Remove partial tag from Tera Blast [Misc][Move] Remove partial tag from Tera Blast Sep 5, 2024
@torranx torranx added Move Affects a move Miscellaneous Changes that don't fit under any other label labels Sep 5, 2024
@innerthunder
Copy link
Collaborator

Tera Blast is marked as partial because of "the lack of Stellar offense typing implementation in the typings", but it already WORKS with stellar types - it's just that it is not yet obtainable in-game

Aren't Stellar Tera Shards already available? I thought they were just rarer than other tera shards

Copy link
Collaborator

@Tempo-anon Tempo-anon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have stellar shards though?

@torranx
Copy link
Collaborator Author

torranx commented Sep 5, 2024

Updated the description @Tempo-anon @innerthunder

@frutescens frutescens added this pull request to the merge queue Sep 5, 2024
Merged via the queue into pagefaultgames:beta with commit deac314 Sep 5, 2024
4 checks passed
@torranx torranx deleted the move/tera_blast branch October 4, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Miscellaneous Changes that don't fit under any other label Move Affects a move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants