Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move] Make protection moves fail when used last in a turn #4045

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

innerthunder
Copy link
Collaborator

What are the changes the user will see?

The following moves now fail if the user is last to move, mirroring their behavior in mainline:

  • Protect and its offshoots (e.g. Spiky Shield)
  • Endure
  • Wide Guard
  • Quick Guard
  • Mat Block
  • Crafty Shield

Why am I making these changes?

closes #1746

What are the changes from a developer perspective?

  • data/move: New failIfLastCondition causes moves with the condition to fail if the user is last to move on that turn.
  • test/moves/protect.test and test/moves/quick_guard.test: New tests checking the new fail condition.

Screenshots/Videos

How to test the changes?

npm run test protect
npm run test quick_guard

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [?] Are the changes visual?
    • [?] Have I provided screenshots/videos of the changes?

@innerthunder innerthunder requested a review from a team as a code owner September 5, 2024 08:05
@innerthunder innerthunder added the Move Affects a move label Sep 5, 2024
@innerthunder innerthunder linked an issue Sep 5, 2024 that may be closed by this pull request
@Tempo-anon Tempo-anon added this pull request to the merge queue Sep 5, 2024
Merged via the queue into pagefaultgames:beta with commit 6e26db2 Sep 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Move Affects a move
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Protect does not fail when it is supposed to
4 participants