Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Missing endless end dialogue #4069

Merged

Conversation

flx-sta
Copy link
Collaborator

@flx-sta flx-sta commented Sep 6, 2024

What are the changes the user will see?

They will see the actual endless end dialogue

Why am I making these changes?

It was only displaying ending_endless because the PGM prefix was still present

What are the changes from a developer perspective?

PGM prefix was removed. Gender context is now passed

Screenshots/Videos

Before

📷 Screenshot (Before)

image

After

Screen.Recording.2024-09-06.at.9.48.32.AM.mov

How to test the changes?

Overrides

const overrides = {
  STARTING_WAVE_OVERRIDE: 5850,
  OPP_LEVEL_OVERRIDE: 1,
  OPP_SPECIES_OVERRIDE: Species.MAGIKARP,
  STARTING_LEVEL_OVERRIDE: 10000,
} satisfies Partial<InstanceType<typeof DefaultOverrides>>;

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • [ ] Have I considered writing automated tests for the issue?
  • [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

It was only displaying `ending_endless` because the `PGM` prefix was still present
@flx-sta flx-sta added the P2 Bug Minor. Non crashing Incorrect move/ability/interaction label Sep 6, 2024
@flx-sta flx-sta marked this pull request as ready for review September 6, 2024 17:05
@flx-sta flx-sta requested a review from a team as a code owner September 6, 2024 17:05
@Tempo-anon Tempo-anon added P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. and removed P2 Bug Minor. Non crashing Incorrect move/ability/interaction labels Sep 6, 2024
@CodeTappert CodeTappert added this pull request to the merge queue Sep 6, 2024
Merged via the queue into pagefaultgames:beta with commit d830442 Sep 6, 2024
4 checks passed
@flx-sta flx-sta deleted the bug/missing-endless-end-dialogue branch September 6, 2024 17:27
@Snailman11
Copy link
Collaborator

Closes #3980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants