Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Hotfix] Revert "[Sprite] 451 - Skorupi Animation Fix" #4535

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

pom-eranian
Copy link
Collaborator

Reverted same files on main as this PR on beta

What are the changes the user will see?

User will no longer crash if the battle has a fusion with skorupi as the second pokemon.

Why am I making these changes?

Multiple users reported this issue

What are the changes from a developer perspective?

Reverted the change on assets for skorupi(451):

  • front png
  • front json
  • shiny front png
  • shiny front json

Screenshots/Videos

Live

5036ea5b-698b-4f6d-bc9a-fc8ed9928966

This PR

3b6236aa-c33f-487c-baf0-b6cc9fac0f5e

Checklist

- [ ] I'm using beta as my base branch hotfix

  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
    - [ ] Have I considered writing automated tests for the issue?
    - [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@pom-eranian pom-eranian marked this pull request as ready for review October 1, 2024 19:17
@pom-eranian pom-eranian requested a review from a team as a code owner October 1, 2024 19:17
Copy link
Collaborator

@MokaStitcher MokaStitcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, crash no longer happens

@Tempo-anon Tempo-anon merged commit 160b730 into pagefaultgames:main Oct 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants