Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2][Move] Fix Tera Shell to apply to all hits of multi-strike moves #4541

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

innerthunder
Copy link
Collaborator

What are the changes the user will see?

Tera Shell now correctly reduces the effectiveness of all hits of multi-strike moves instead of just the first hit.

Why am I making these changes?

closes #4218

What are the changes from a developer perspective?

  • field/pokemon: Added new moveEffectiveness field to turnData which caches a move effectiveness value for the current move being used against the associated Pokemon. If not null, this value overrides the output of Pokemon.getMoveEffectiveness(...). This field is currently only used for and modified by Tera Shell's effect.
  • data/ability: Tera Shell now changes pokemon.turnData.moveEffectiveness to 0.5 when the ability applies.
  • phases/move-effect-phase: now resets target.turnData.moveEffectiveness for all targets of the phase's move on the move's last strike.
  • test/abilities/tera_shell.test: New test for Tera Shell covering all hits of a multi-strike move (specifically Double Hit).

Screenshots/Videos

How to test the changes?

npm run test tera_shell (includes new test)

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [?] Are the changes visual?
    • [?] Have I provided screenshots/videos of the changes?

@innerthunder innerthunder requested a review from a team as a code owner October 1, 2024 23:09
@innerthunder innerthunder added P2 Bug Minor. Non crashing Incorrect move/ability/interaction Move Affects a move labels Oct 1, 2024
frutescens
frutescens previously approved these changes Oct 1, 2024
DayKev
DayKev previously approved these changes Oct 2, 2024
Copy link
Collaborator

@DayKev DayKev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the obsolete ! and comment from L357 in move-effect-phase.ts too please?

@innerthunder innerthunder dismissed stale reviews from DayKev and frutescens via 0717b31 October 2, 2024 00:41
@Tempo-anon Tempo-anon merged commit 7473c31 into pagefaultgames:beta Oct 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Move Affects a move P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Tera Shell only Considers the First Hit when Modifying Type Effectiveness
4 participants