[Move] Fully Implement Secret Power

[frutescens]

What are the changes the user will see?

Secret Power will be fully implemented and will now have its secondary effect.

Why am I making these changes?

Must implement moves...

What are the changes from a developer perspective?

New Move Attribute -> SecretPowerAttr

Screenshots/Videos

Screen.Recording.2024-10-14.at.7.25.44.PM.mov

How to test the changes?

Use Secret Power with a valid Terrain or Biome.

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[Tempo-anon]

Can you add a test to see if this is doubled by serene grace but not the rainbow pledge?

[torranx]

shouldn't the test cases be "applies x effect when y biome is active"?

[frutescens]

I think that I wanted to use the tests to display corner or edge cases + there's around 25 biomes so it may be too many tests. Open to your thoughts though.

[DayKev]

It seems a bit excessive to have ~30 tests for a single move. Ensuring basic functionality + edge cases is probably good enough.

[DayKev]

Suggested change

	apply(user: Pokemon, target: Pokemon, move: Move, args?: any[] | undefined): boolean | Promise<boolean> {
	let secondaryEffect: MoveAttr;
	apply(user: Pokemon, target: Pokemon, move: Move, args?: any[]): boolean | Promise<boolean> {
	let secondaryEffect: MoveEffectAttr;

Not sure it matters too much, but all the invoked attrs extend MoveEffectAttr.

[DayKev]

It seems a bit excessive to have ~30 tests for a single move. Ensuring basic functionality + edge cases is probably good enough.