Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P3][Beta] Fix missing move text when a move fails #4664

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

innerthunder
Copy link
Collaborator

What are the changes the user will see?

This fixes an issue in beta where "{Pokemon} used {Move}!" would not appear when the move would fail, instead immediately showing "But it failed!"

Why am I making these changes?

Reported in the Discord

What are the changes from a developer perspective?

phases/move-phase:

  • Restored a missing call to showMoveText when the move being used would fail or be cancelled.
  • resolveFinalPreMoveCancellationChecks now uses this.cancel() instead of directly setting this.cancelled.

Screenshots/Videos

PokeRogue.-.Google.Chrome.2024-10-14.16-58-37.mp4

How to test the changes?

  1. Download DOUBLESMEMENTO.txt and change the file extension to .prsv. Load this file as session data onto a local build
  2. On the first turn, use Liquidation on both Shuckle and Regieleki. Both enemies should use Memento and faint, causing Shuckle's Liquidation to fail.
  3. The text "Shuckle used Liquidation!" should show when it gets to Shuckle's turn.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@innerthunder innerthunder requested a review from a team as a code owner October 15, 2024 00:21
@innerthunder innerthunder added P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. Beta Only present on Beta (didn't make it into production [yet]) labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beta Only present on Beta (didn't make it into production [yet]) P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions.
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants