Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PN-9088: add connection and read timeout for assertion and IDP client #94

Merged
merged 1 commit into from
Dec 6, 2024
Merged

PN-9088: add connection and read timeout for assertion and IDP client #94

merged 1 commit into from
Dec 6, 2024

Conversation

masciale89
Copy link
Contributor

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@masciale89 masciale89 marked this pull request as ready for review December 5, 2024 09:05
pp-ps
pp-ps approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@pp-ps pp-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sebbalex?

@masciale89 masciale89 merged commit 074ebef into main Dec 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp-ps pp-ps pp-ps approved these changes

@sebbalex sebbalex sebbalex approved these changes

@gquadrati gquadrati Awaiting requested review from gquadrati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masciale89 @sebbalex @pp-ps