Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GitHub Action for Dockerfile release update and slack notification #38

Merged
merged 83 commits into from
Aug 1, 2024

Conversation

mamu0
Copy link
Contributor

@mamu0 mamu0 commented Jul 2, 2024

List of Changes

  1. Adding the GitHub Action.
  2. Added the release.json file, which contain the values of the latest release. This variables are used to store the tag and SHA of the latest installed version.
    {
      "current_tag": "vX.Y.Z",
      "current_sha": "XXXXXX"
    }
    
  3. Making a minor fix to the .gitignore file.
  4. Enabling “Allow GitHub Actions to create and approve pull requests” in Repository Settings -> Actions -> General.
  5. Added a variable for SLACK WEBOOK SECRET to use inside the workflow

Motivation and Context

This PR aims to create a GitHub Action that checks if a new release has been published on the repository https://github.com/actions/runner. If a new release is found, the action retrieves the necessary information to update the FROM directive in the Dockerfile to reference the new release.

Additionally, a changelog has been added, which is an MD file that keeps track of the versions that have been installed over time.

How Has This Been Tested?

This has been tested by running the action multiple times to verify that the values were correct. The PR generation part has been tested in a private repository.

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mamu0 mamu0 marked this pull request as ready for review July 10, 2024 09:42
@pasqualedevita
Copy link
Member

for slack notification you can also use github integration with summary. This not realtime but I think that one or two trigger per day can be enough

Less code is better :)

@Krusty93
Copy link
Contributor

for slack notification you can also use github integration with summary. This not realtime but I think that one or two trigger per day can be enough

Less code is better :)

Does it send an email everyday or only if there is at least a PR?

@mamu0 mamu0 marked this pull request as draft July 31, 2024 07:28
@mamu0 mamu0 marked this pull request as ready for review July 31, 2024 07:48
@mamu0 mamu0 requested review from Krusty93 and pasqualedevita July 31, 2024 07:48
@pasqualedevita
Copy link
Member

thanks @mamu0 very useful improvement :)))

@pasqualedevita pasqualedevita merged commit e75a0c2 into main Aug 1, 2024
5 checks passed
@pasqualedevita pasqualedevita deleted the EC-340-action-update-dockerfile branch August 1, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants