Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental detox based tests #145

Merged
merged 34 commits into from
Jul 9, 2018
Merged

Experimental detox based tests #145

merged 34 commits into from
Jul 9, 2018

Conversation

cloudify
Copy link
Contributor

Experimental tests based on Detox (currently iOS only)

detox-tests

@cloudify cloudify changed the title Experimental detox based tests [WIP] Experimental detox based tests May 16, 2018
@cloudify cloudify force-pushed the experimental-detox-tests branch 2 times, most recently from 45fedac to 4e380ba Compare May 16, 2018 17:34
@digitalcitizenship
Copy link

digitalcitizenship commented May 16, 2018

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

⚠️

Remember to fix the PR title by removing WIP wording when ready

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

New dependencies added: @types/node and detox.

@types/node

Author: Unknown

Description: TypeScript definitions for Node.js

Homepage: http://npmjs.com/package/@types/node

Createdabout 2 years ago
Last Updated3 days ago
LicenseMIT
Maintainers1
Releases384
Direct Dependencies
README

Installation

npm install --save @types/node

Summary

This package contains type definitions for Node.js (http://nodejs.org/).

Details

Files were exported from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node

Additional Details

  • Last updated: Fri, 06 Jul 2018 00:07:02 GMT
  • Dependencies: none
  • Global values: Buffer, NodeJS, SlowBuffer, Symbol, __dirname, __filename, clearImmediate, clearInterval, clearTimeout, console, exports, global, module, process, require, setImmediate, setInterval, setTimeout

Credits

These definitions were written by Microsoft TypeScript http://typescriptlang.org, DefinitelyTyped https://github.com/DefinitelyTyped/DefinitelyTyped, Parambir Singh https://github.com/parambirs, Christian Vaagland Tellnes https://github.com/tellnes, Wilco Bakker https://github.com/WilcoBakker, Nicolas Voigt https://github.com/octo-sniffle, Chigozirim C. https://github.com/smac89, Flarna https://github.com/Flarna, Mariusz Wiktorczyk https://github.com/mwiktorczyk, wwwy3y3 https://github.com/wwwy3y3, Deividas Bakanas https://github.com/DeividasBakanas, Kelvin Jin https://github.com/kjin, Alvis HT Tang https://github.com/alvis, Sebastian Silbermann https://github.com/eps1lon, Hannes Magnusson https://github.com/Hannes-Magnusson-CK, Alberto Schiabel https://github.com/jkomyno, Klaus Meinhardt https://github.com/ajafff, Huw https://github.com/hoo29, Nicolas Even https://github.com/n-e, Bruno Scheufler https://github.com/brunoscheufler, Mohsen Azimi https://github.com/mohsen1, Hoàng Văn Khải https://github.com/KSXGitHub, Alexander T. https://github.com/a-tarasyuk, Lishude https://github.com/islishude, Andrew Makarov https://github.com/r3nya, Zane Hannan AU https://github.com/ZaneHannanAU.

detox

Author: Tal Kol

Description: E2E tests and automation for mobile

Homepage: https://github.com/wix/detox#readme

Createdover 3 years ago
Last Updated12 days ago
LicenseMIT
Maintainers6
Releases106
Direct Dependencieschild-process-promise, commander, detox-server, fs-extra, get-port, ini, lodash, minimist, npmlog, proper-lockfile, shell-utils, tail, telnet-client, tempfile and ws

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented May 16, 2018

Codecov Report

Merging #145 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   38.24%   38.24%           
=======================================
  Files         115      115           
  Lines        1331     1331           
  Branches      221      221           
=======================================
  Hits          509      509           
  Misses        819      819           
  Partials        3        3

@fpersico
Copy link
Contributor

Looks good. Let me know if you need my help in some way.

@cloudify
Copy link
Contributor Author

Thanks, I'm going to trying a couple things more (navigation and taking screenshots) - I think we will also have to create a Docker image that sets up the local IdP for logging in with SPID (unless we can use the AgID IdP) - cc @lussoluca

@fpersico
Copy link
Contributor

fpersico commented May 18, 2018

@cloudify Screenshots and other usefull stuff are goin to be merged soon in detox with this PR wix/Detox#734

In the meantime you can use this snipplet to take screenshot on ios https://gist.github.com/cjcaj/8c25bb5538f54a4810dc36025aa7a3d8#file-helpers-js

@cloudify cloudify force-pushed the experimental-detox-tests branch 3 times, most recently from 6c9bda1 to f477f2d Compare May 25, 2018 11:01
@cloudify
Copy link
Contributor Author

This is currently failing with a timeout from the simulator (works fine locally) - I suspect it's related to wix/Detox#155

@cloudify
Copy link
Contributor Author

cloudify commented Jun 3, 2018

Possible fix: wix/Detox#689

@cloudify cloudify force-pushed the experimental-detox-tests branch from 43cdd10 to 9202ca5 Compare June 7, 2018 12:36
@cloudify cloudify force-pushed the experimental-detox-tests branch from 8e4ddc6 to 26e4988 Compare June 19, 2018 07:40
@cloudify cloudify force-pushed the experimental-detox-tests branch from 0916fc7 to 41a716e Compare July 7, 2018 09:17
@cloudify cloudify requested a review from fpersico July 7, 2018 09:52
@cloudify cloudify force-pushed the experimental-detox-tests branch from 33d336e to 2ab08fa Compare July 8, 2018 07:20
@cloudify
Copy link
Contributor Author

cloudify commented Jul 9, 2018

Tests are a little flacky on circleci due to the restricted resources of the VM, merging for now.

@cloudify cloudify merged commit c8ef8bd into master Jul 9, 2018
@cloudify cloudify deleted the experimental-detox-tests branch July 9, 2018 09:01
@cloudify cloudify changed the title [WIP] Experimental detox based tests Experimental detox based tests Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants