Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IA-595] Hide show tickets button #3605

Merged
merged 19 commits into from
Dec 22, 2021

Conversation

debiff
Copy link
Contributor

@debiff debiff commented Dec 21, 2021

THIS PR DEPENDS ON pagopa/io-react-native-zendesk#12

Short description

This PR hide the show tickets button if the user has never created a ticket.

List of changes proposed in this pull request

  • Upgrade io-react-native-zendesk to the version 0.3.13
  • Show the show tickets button only if the user has created at least one ticket
Simulator.Screen.Recording.-.iPhone.12.-.2021-12-21.at.19.01.35.mp4
Screen.Recording.2021-12-21.at.19.16.33.mov

How to test

Try to remove the app, press the assistance button.
Then try to open a ticket.
Finally try to press again the assistance button.

@debiff debiff requested a review from a team as a code owner December 21, 2021 18:18
@fabriziofff fabriziofff self-assigned this Dec 21, 2021
@Undermaken
Copy link
Contributor

@debiff you should commit also yarn.lock and Podfile.lock
try to run yarn install;cd ios;pod install;

@debiff
Copy link
Contributor Author

debiff commented Dec 22, 2021

@debiff you should commit also yarn.lock and Podfile.lock try to run yarn install;cd ios;pod install;

Yes sure, commited in e81b4ce

@pagopa-github-bot pagopa-github-bot changed the title [IA-595] Hide show tickets button chore: [IA-595] Hide show tickets button Dec 22, 2021
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 22, 2021

Affected stories

  • ⚙️ IA-595: Se non ci sono ticket nascondere il pulsante mostra ticket

Generated by 🚫 dangerJS against 462dab3

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #3605 (462dab3) into master (54def91) will increase coverage by 0.00%.
The diff coverage is 82.05%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3605   +/-   ##
=======================================
  Coverage   73.01%   73.02%           
=======================================
  Files         812      813    +1     
  Lines       19727    19756   +29     
  Branches     3901     3907    +6     
=======================================
+ Hits        14403    14426   +23     
- Misses       5205     5210    +5     
- Partials      119      120    +1     
Impacted Files Coverage Δ
.../zendesk/saga/networking/handleHasOpenedTickets.ts 62.50% <62.50%> (ø)
ts/features/zendesk/saga/index.ts 63.63% <66.66%> (-3.04%) ⬇️
ts/features/zendesk/store/reducers/index.ts 60.52% <72.72%> (+5.35%) ⬆️
...res/zendesk/components/ZendeskSupportComponent.tsx 92.98% <100.00%> (+1.14%) ⬆️
ts/features/zendesk/store/actions/index.ts 100.00% <100.00%> (ø)
ts/utils/supportAssistance.ts 75.55% <100.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54def91...462dab3. Read the comment docs.

@debiff debiff requested a review from Undermaken December 22, 2021 09:01
Copy link
Contributor

@Undermaken Undermaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Leave to @fabriziofff for his approval and merge 😉

@fabriziofff fabriziofff merged commit 0762115 into master Dec 22, 2021
@fabriziofff fabriziofff deleted the IA-595-hide-already-opened-ticket-button branch December 22, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants