-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [PE-553] CGN discount screen revamp #6087
Conversation
…a/io-app into PE-553-cgn-discount-revamp
@Hantex9 few general questions:
|
|
Removed unused translation labels in the following commit: 61156f0 |
Thank you for pointing that out. Based on the comment left on Figma, it seems to be a design oversight, as with the current attributes provided by the backend, we are not able to determine when to display that banner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR adds new screens and refactors the previous ones related to the detailed discount screens with another screen where the discount code might appear or show the webview with the discount landing page.
Designed Figma
https://www.figma.com/design/yOoBGDr1MJpa0LY5lDUFSd/IOapp_CartaGiovaniNazionale?node-id=6102-36816&t=ek5UqE6BwEaiVSgb-4
List of changes proposed in this pull request
CgnMerchantDiscountItem
component removing the older hook that was used to show a bottom sheet with the discount details;CgnDiscountDetailScreen
: It's used to show the discount detailsCgnDiscountCodeScreen
: It's used to show the discount code if the provided discount is any type ofapi
,staticCode
orbucketCode
;selectMerchantDiscount
action used to pick the discount details when the user tap on its details;setMerchantDiscountCode
action used to set the discount code to show in theCgnDiscountCodeScreen
when the user taps on theGenerate/Show discount code
CTA;N.B: Tests of these pages will follow in another PR with another jira ticket
How to test
LANDING-PAGE.mov
static-code.mov
bucket-code.mov
api.mov